From: Christopher Li <sparse@chrisli.org>
To: Pavel Roskin <plroskin@gmail.com>
Cc: Linux-Sparse <linux-sparse@vger.kernel.org>
Subject: Re: [PATCH] Add -gcc-version option
Date: Wed, 19 Jul 2017 09:07:03 -0400 [thread overview]
Message-ID: <CANeU7Q=HYVQY3HkSqKPekxSMhzFsxpV2UV905h3Qyf2sNGF1ug@mail.gmail.com> (raw)
In-Reply-To: <CAN_72e2SE4pcUNNUSOJVRW31YdXmm-tR0ybOjpT7QDV2fmne4g@mail.gmail.com>
On Tue, Jul 18, 2017 at 7:46 PM, Pavel Roskin <plroskin@gmail.com> wrote:
> Yes, that works! I wish I thought of it earlier and did not waste time
> writing that patch.
>
> That option may still be useful if sparse attempts to imitate the
> behavior of specific gcc versions (in addition to the defines).
I will skip the patch for now. Yes it is more convenient to give one
command line
options and it set 3 macros. I am not sure the complexity justify it.
When you specify the gcc version, there is also implicit version
specific behavior
go with it. I can see user file bugs said I give sparse gcc version X,
but gcc has
macro Y in X. That is not the case with sparse, that is a bug. I don't
want to give
the user false impression that sparse can set a gcc version and simulate the gcc
version specific behavior.
It is simpler just put the version specific macro into a header file and ask
sparse to include it. You should be able to add that to command line as well.
Chris
next prev parent reply other threads:[~2017-07-19 13:07 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-07-18 21:59 [PATCH] Add -gcc-version option Pavel Roskin
2017-07-18 23:35 ` Christopher Li
2017-07-18 23:46 ` Pavel Roskin
2017-07-19 13:07 ` Christopher Li [this message]
2017-07-19 17:27 ` Pavel Roskin
2017-07-19 19:16 ` Christopher Li
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CANeU7Q=HYVQY3HkSqKPekxSMhzFsxpV2UV905h3Qyf2sNGF1ug@mail.gmail.com' \
--to=sparse@chrisli.org \
--cc=linux-sparse@vger.kernel.org \
--cc=plroskin@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).