From: Christopher Li <sparse@chrisli.org>
To: Ramsay Jones <ramsay@ramsay1.demon.co.uk>
Cc: Sparse Mailing-list <linux-sparse@vger.kernel.org>
Subject: Re: [PATCH 06/10] don't run sparse{c,i} tests when sparse-llvm is disabled
Date: Sat, 27 Sep 2014 12:29:44 +0800 [thread overview]
Message-ID: <CANeU7QkFPTW04ECjrJKHO51g38R6r3Rt8jX74PsAnEgpxRqxYw@mail.gmail.com> (raw)
In-Reply-To: <53DFD320.2050903@ramsay1.demon.co.uk>
On Tue, Aug 5, 2014 at 2:38 AM, Ramsay Jones <ramsay@ramsay1.demon.co.uk> wrote:
> +if [ ! -x "$default_path/sparse-llvm" ]; then
> + disabled_cmds="sparsec sparsei sparse-llvm"
> +fi
I think this can be simplified as if the test command was not found,
then that test will be disabled. It doesn't need to be sparse llvm, it
can be other
test program.
We don't need to set an disable_cmds list then check against that list.
Chris
next prev parent reply other threads:[~2014-09-27 4:29 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-08-04 18:38 [PATCH 06/10] don't run sparse{c,i} tests when sparse-llvm is disabled Ramsay Jones
2014-09-27 4:29 ` Christopher Li [this message]
2014-09-27 13:37 ` Ramsay Jones
2014-09-30 3:26 ` Christopher Li
2014-10-02 3:44 ` Christopher Li
2014-10-02 10:31 ` Ramsay Jones
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CANeU7QkFPTW04ECjrJKHO51g38R6r3Rt8jX74PsAnEgpxRqxYw@mail.gmail.com \
--to=sparse@chrisli.org \
--cc=linux-sparse@vger.kernel.org \
--cc=ramsay@ramsay1.demon.co.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).