c2xml uses out of type modifiers mapping

c2xml uses out of type modifiers mapping

[Dibyendu Majumdar]

Hi,

I noticed that the mapping for type modifiers in c2xml is out of sync
with the MOD_* definitions in symbol.h.

Regards
Dibyendu

Re: c2xml uses out of type modifiers mapping

[Christopher Li]

On Tue, Jun 13, 2017 at 3:02 PM, Dibyendu Majumdar
<mobile@majumdar.org.uk> wrote:
> Hi,
>
> I noticed that the mapping for type modifiers in c2xml is out of sync
> with the MOD_* definitions in symbol.h.

Do you mean in function examine_modifiers(), the modifiers[] array
are out of sync? It does look like so.

Patch is welcome :-)

Chris

Re: c2xml uses out of type modifiers mapping

[Dibyendu Majumdar]

Hi Chris,

On 13 June 2017 at 23:16, Christopher Li <sparse@chrisli.org> wrote:
> On Tue, Jun 13, 2017 at 3:02 PM, Dibyendu Majumdar
>> I noticed that the mapping for type modifiers in c2xml is out of sync
>> with the MOD_* definitions in symbol.h.
>
> Do you mean in function examine_modifiers(), the modifiers[] array
> are out of sync? It does look like so.

Yes, that is what I meant.

>
> Patch is welcome :-)
>

Happy to, although cannot promise when, as it means I will have to
setup a sparse repository for the sole purpose of creating patches.
BTW, Is there a guide on how to submit patches?

Thanks and Regards
Dibyendu

Re: c2xml uses out of type modifiers mapping

[Christopher Li]

On Wed, Jun 14, 2017 at 1:51 PM, Dibyendu Majumdar
<mobile@majumdar.org.uk> wrote:
> Hi Chris,
> Happy to, although cannot promise when, as it means I will have to
> setup a sparse repository for the sole purpose of creating patches.
> BTW, Is there a guide on how to submit patches?

You can take the document of submitting patches for Linux kernel.
Of course replace the kernel bits to sparse. Sparse using the same
coding stander
as the Linux kernel. The git work flow you need to do is very similar.

https://www.kernel.org/doc/html/v4.11/process/submitting-patches.html

Chris