From: Christopher Li <sparse@chrisli.org>
To: Pekka Enberg <penberg@kernel.org>
Cc: Benjamin Herrenschmidt <benh@kernel.crashing.org>,
Jeff Garzik <jeff@garzik.org>,
linux-sparse@vger.kernel.org,
Linus Torvalds <torvalds@linux-foundation.org>,
Jeff Garzik <jgarzik@redhat.com>
Subject: Re: [RFC/PATCH 1/2] sparse, llvm: Make function declaration accessible to backend
Date: Sat, 4 Feb 2012 04:20:46 -0800 [thread overview]
Message-ID: <CANeU7QmdK-MJofqB8frCVJHyfce07yYBU7_3cLO_8-NkEuo4tA@mail.gmail.com> (raw)
In-Reply-To: <CAOJsxLHku6vzYbaOf9tPOY0VwMEcJ3Te63DYqvs+S2+-W9oFdA@mail.gmail.com>
On Fri, Feb 3, 2012 at 1:09 AM, Pekka Enberg <penberg@kernel.org> wrote:
> On Thu, Feb 2, 2012 at 4:10 AM, Christopher Li <sparse@chrisli.org> wrote:
>> Yes, that is the point my counter RFC. When you look at it, the
>> insn->fntype is really type of the insn->func pseudo. That is a one off
>> thing for call instruction. Store type inside pseudo provide the same
>> functionality and unify how to get type from pseudo.
>
> Ping? I'd really like to have this bug fixed because it affects basic
> "hello, world" on x86-64 and PPC.
Hi Pekka,
Sorry I get really spaced. Can you continue apply that into your sparse-llvm
repository? The insn->type to pseudo->ctype change is actually impact a
lot of code. I haven't able to complete it yet. On the other hand, I
don't want you
to block on it. The more I look at it, the more I believe this is the
right thing
to do. Pseudo come from expressions, the pseudo->ctype is just the expr->ctype.
We will merge the sparse-llvm again when I get this sort out. One good thing
about git is that branch and merge is really easy. I you to continue
the sparse-llvm
repository. I can submit some llvm related patch for you to review as well.
sparse-llvm.c is the biggest user of insn->type right now. I want to simplify
the usage a little bit.
Thanks
Chris
next prev parent reply other threads:[~2012-02-04 12:20 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-02-01 9:55 [RFC/PATCH 1/2] sparse, llvm: Make function declaration accessible to backend Pekka Enberg
2012-02-01 9:55 ` [RFC/PATCH 2/2] sparse, llvm: Fix varargs functions Pekka Enberg
2012-02-01 10:47 ` Benjamin Herrenschmidt
2012-02-01 13:58 ` Jeff Garzik
2012-02-02 0:09 ` [RFC/PATCH 1/2] sparse, llvm: Make function declaration accessible to backend Christopher Li
2012-02-02 0:54 ` Benjamin Herrenschmidt
2012-02-02 6:28 ` Pekka Enberg
2012-02-02 1:03 ` Jeff Garzik
2012-02-02 1:22 ` Benjamin Herrenschmidt
2012-02-02 1:33 ` Christopher Li
2012-02-02 1:50 ` Benjamin Herrenschmidt
2012-02-02 2:10 ` Christopher Li
2012-02-03 9:09 ` Pekka Enberg
2012-02-03 11:31 ` Benjamin Herrenschmidt
2012-02-04 12:20 ` Christopher Li [this message]
2012-02-04 12:56 ` Pekka Enberg
2012-02-04 15:27 ` Linus Torvalds
2012-02-04 15:34 ` Pekka Enberg
2012-02-02 1:22 ` Christopher Li
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CANeU7QmdK-MJofqB8frCVJHyfce07yYBU7_3cLO_8-NkEuo4tA@mail.gmail.com \
--to=sparse@chrisli.org \
--cc=benh@kernel.crashing.org \
--cc=jeff@garzik.org \
--cc=jgarzik@redhat.com \
--cc=linux-sparse@vger.kernel.org \
--cc=penberg@kernel.org \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).