linux-sparse.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* Suggestion for fixing the variable length array used in the kernel.
@ 2013-03-07  4:46 Christopher Li
  2013-03-09  0:29 ` Andrew Morton
  0 siblings, 1 reply; 7+ messages in thread
From: Christopher Li @ 2013-03-07  4:46 UTC (permalink / raw)
  To: linux-kernel; +Cc: Linux-Sparse, Linus Torvalds

Hi,

I am looking at the current sparse warning on the kernel source.
One category of those warning are produce by the variable length array.
We all know that the kernel stack has a limit so we don't want to allocate
too much stack to the variable size array.

Is there a recommended way to fix those warnings? Is it worth while to
fix it at all? I am looking forward to some kind of guideline how to handle
this.


Some of them has estimated size limited, like the one fournd in decode_rs.c

	/* Err+Eras Locator poly and syndrome poly The maximum value
	 * of nroots is 8. So the necessary stack size will be about
	 * 220 bytes max.
	 */
	uint16_t lambda[nroots + 1], syn[nroots];
	uint16_t b[nroots + 1], t[nroots + 1], omega[nroots + 1];
	uint16_t root[nroots], reg[nroots + 1], loc[nroots];

Some of them did not said the size estimation but you kind of know
they are not likely to blow up the stack:
In xen_flush_tlb_others

	struct {
		struct mmuext_op op;
#ifdef CONFIG_SMP
		DECLARE_BITMAP(mask, num_processors);
#else
		DECLARE_BITMAP(mask, NR_CPUS);
#endif
	} *args;

And also some of them are harder to tell from the context if
there will be a size limit:

int snd_pcm_hw_refine(struct snd_pcm_substream *substream,
		      struct snd_pcm_hw_params *params)
{
	unsigned int k;
	struct snd_pcm_hardware *hw;
	struct snd_interval *i = NULL;
	struct snd_mask *m = NULL;
	struct snd_pcm_hw_constraints *constrs = &substream->runtime->hw_constraints;
	unsigned int rstamps[constrs->rules_num]; <---------------------------------


Chris

^ permalink raw reply	[flat|nested] 7+ messages in thread
end of thread, other threads:[~2013-03-10 11:39 UTC | newest]

Thread overview: 7+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-03-07  4:46 Suggestion for fixing the variable length array used in the kernel Christopher Li
2013-03-09  0:29 ` Andrew Morton
2013-03-09  5:39   ` Dan Carpenter
2013-03-09 18:10     ` Christopher Li
2013-03-09 22:34       ` Dan Carpenter
2013-03-09 23:00         ` Christopher Li
2013-03-10 11:38           ` Dan Carpenter

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).