From: Christopher Li <sparse@chrisli.org>
To: Ramsay Jones <ramsay@ramsay1.demon.co.uk>
Cc: Sparse Mailing-list <linux-sparse@vger.kernel.org>
Subject: Re: [PATCH 0/4] chrisl master branch patches
Date: Sun, 12 Oct 2014 17:22:50 +0800 [thread overview]
Message-ID: <CANeU7QnDim5JuSO5HBgBgwUVu1cGDyBwcAKUTVY-vQKjfrBiLw@mail.gmail.com> (raw)
In-Reply-To: <54398B23.8080501@ramsay1.demon.co.uk>
On Sun, Oct 12, 2014 at 3:55 AM, Ramsay Jones
<ramsay@ramsay1.demon.co.uk> wrote:
> Hi Chris,
>
> I don't know how you like to manage your public repo, but if you
> don't mind re-winding your master branch, then you could squash
> patch #1 into commit e23abfd and patch #2 into fe57afa.
I should have try the review branch. Now it is push to master.
I can't rewind it.
>
> The final patch is a possible alternative to "[PATCH 04/10]
> compile-i386.c: don't mix calls to write(2) with stdio", which
> basically just removes the compile program. If you prefer
> another solution, just let me know.
I think I would just keep it as example of using the sparse
front end AST. For compiling, the sparse-llvm does a better job
there.
>
> [Note: I have been living with the RFC patch #10 for quite a
> while now with no problems. However, it was just a quick hack
> to speed up cgcc/sparse on Cygwin and, on reflection, not a
> good reason to introduce a sparse configuration file! Also, the
> use of the perl language for the config file can be viewed as
> a bit cute (too cute for some people). I will probably keep it
> as a locally applied patch on cygwin (it is a noticeable speedup
> on cygwin), but remove it on Linux.]
It seems scary the config file you can put any perl code there.
Any way, I think in the long term, it is better move cgcc stuff
into sparse. So sparse do not need to have a wrapper to setup
the compiling environment. To speed up things, it is best
to invoke sparse without a wrapper. That is how it is done in
the kernel checking.
Chris
next prev parent reply other threads:[~2014-10-12 9:22 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-10-11 19:55 [PATCH 0/4] chrisl master branch patches Ramsay Jones
2014-10-12 9:22 ` Christopher Li [this message]
2014-10-13 22:58 ` Ramsay Jones
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CANeU7QnDim5JuSO5HBgBgwUVu1cGDyBwcAKUTVY-vQKjfrBiLw@mail.gmail.com \
--to=sparse@chrisli.org \
--cc=linux-sparse@vger.kernel.org \
--cc=ramsay@ramsay1.demon.co.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).