From mboxrd@z Thu Jan 1 00:00:00 1970 From: Christopher Li Subject: Re: [PATCH] remove warning "call with no type" Date: Sat, 10 Feb 2018 11:00:26 -0800 Message-ID: References: <20180131104043.3345-1-luc.vanoostenryck@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Return-path: Received: from mail-qk0-f181.google.com ([209.85.220.181]:36661 "EHLO mail-qk0-f181.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752003AbeBJTA2 (ORCPT ); Sat, 10 Feb 2018 14:00:28 -0500 Received: by mail-qk0-f181.google.com with SMTP id 15so14029416qkl.3 for ; Sat, 10 Feb 2018 11:00:27 -0800 (PST) In-Reply-To: <20180131104043.3345-1-luc.vanoostenryck@gmail.com> Sender: linux-sparse-owner@vger.kernel.org List-Id: linux-sparse@vger.kernel.org To: Luc Van Oostenryck Cc: Linux-Sparse On Wed, Jan 31, 2018 at 2:40 AM, Luc Van Oostenryck wrote: > This warning is issued when trying to linearize a call > expressions with a null expr->ctype but such null ctype > is a consequence of an error detected during evaluation > and this error must already have issued a warning or an > error message specific to the problem. > > In short, this "call with no type" is non-informative > and redundant, so avoid usless noise and remove this > warning. The change looks fine to me. This the change assume the expr->ctype be NULL is result of an error and has been reported before. I am sure that assumption holds for most of the cases. Not sure it holds for all corner cases. On the other hand, if the expr->ctype is NULL, it is already screwed, change it to VOID is not too bad. Chris