From: Pekka Enberg <penberg@kernel.org>
To: Jeff Garzik <jgarzik@pobox.com>
Cc: "Jonathan Neuschäfer" <j.neuschaefer@gmx.net>,
linux-sparse@vger.kernel.org,
"Christopher Li" <sparse@chrisli.org>,
"Jeff Garzik" <jgarzik@redhat.com>,
"Linus Torvalds" <torvalds@linux-foundation.org>
Subject: Re: [PATCH] sparse, llvm: convert the condition of branch/select to bool
Date: Sun, 19 Aug 2012 20:02:33 +0300 [thread overview]
Message-ID: <CAOJsxLEvgodTi0kPNLQPm5hwwVwZN_cQALWCWbWfvN0G0PzarA@mail.gmail.com> (raw)
In-Reply-To: <50311947.7080700@pobox.com>
On Sun, Aug 19, 2012 at 7:50 PM, Jeff Garzik <jgarzik@pobox.com> wrote:
> On 08/19/2012 10:52 AM, Jonathan Neuschäfer wrote:
>>
>> LLVM expects the first argument of "br" and "select" to be of type i1,
>> so add an "icmp ne <srcty> %src, 0" for other types.
>>
>> Cc: Pekka Enberg <penberg@kernel.org>
>> Cc: Christopher Li <sparse@chrisli.org>
>> Cc: Jeff Garzik <jgarzik@redhat.com>
>> Cc: Linus Torvalds <torvalds@linux-foundation.org>
>> Signed-off-by: Jonathan Neuschäfer <j.neuschaefer@gmx.net>
>> ---
>> sparse-llvm.c | 13 +++++++++++--
>> validation/backend/int-cond.c | 30 ++++++++++++++++++++++++++++++
>> 2 files changed, 41 insertions(+), 2 deletions(-)
>> create mode 100644 validation/backend/int-cond.c
>
>
> Nice -- and I wonder if this fixes the loop bug Pekka noted in private email
> on 2011/11/23?
>
> Pekka, do you mind if I forward your email to the list?
No, not at all. Feel free to forward it.
--
To unsubscribe from this list: send the line "unsubscribe linux-sparse" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
prev parent reply other threads:[~2012-08-19 17:02 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-08-19 14:52 [PATCH] sparse, llvm: convert the condition of branch/select to bool Jonathan Neuschäfer
2012-08-19 15:13 ` Pekka Enberg
2012-08-19 16:50 ` Jeff Garzik
2012-08-19 17:02 ` Pekka Enberg [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAOJsxLEvgodTi0kPNLQPm5hwwVwZN_cQALWCWbWfvN0G0PzarA@mail.gmail.com \
--to=penberg@kernel.org \
--cc=j.neuschaefer@gmx.net \
--cc=jgarzik@pobox.com \
--cc=jgarzik@redhat.com \
--cc=linux-sparse@vger.kernel.org \
--cc=sparse@chrisli.org \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).