From: Wei Yongjun <weiyj.lk@gmail.com>
To: gaowanlong@cn.fujitsu.com
Cc: josh@kernel.org, linux-sparse@vger.kernel.org,
rusty@rustcorp.com.au, ak@linux.intel.com,
fengguang.wu@intel.com, kbuild-all@01.org
Subject: Re: [BUG report] sparse warnings about "__ksymtab_*" symbols
Date: Tue, 26 Nov 2013 10:15:43 +0800 [thread overview]
Message-ID: <CAPgLHd-WGDSeSg6By8ik1c26nBAw54wkL7NvZZwjR4O8y-Ho1g@mail.gmail.com> (raw)
In-Reply-To: <5293FEA6.2080101@cn.fujitsu.com>
ref to http://www.spinics.net/lists/linux-sparse/msg03297.html
On 11/26/2013 09:51 AM, Wanlong Gao wrote:
> Hi folks,
>
> After following kernel commit[1](find through bisect), We can see many sparse warnings like:
> "
> /git/linux/kernel/time/timekeeping.c:229:1: warning: symbol '__ksymtab_pvclock_gtod_register_notifier' was not declared. Should it be static?
> /git/linux/kernel/time/timekeeping.c:246:1: warning: symbol '__ksymtab_pvclock_gtod_unregister_notifier' was not declared. Should it be static?
> /git/linux/kernel/time/timekeeping.c:323:1: warning: symbol '__ksymtab___getnstimeofday' was not declared. Should it be static?
> /git/linux/kernel/time/timekeeping.c:335:1: warning: symbol '__ksymtab_getnstimeofday' was not declared. Should it be static?
> /git/linux/kernel/time/timekeeping.c:357:1: warning: symbol '__ksymtab_ktime_get' was not declared. Should it be static?
> /git/linux/kernel/time/timekeeping.c:388:1: warning: symbol '__ksymtab_ktime_get_ts' was not declared. Should it be static?
> /git/linux/kernel/time/timekeeping.c:417:1: warning: symbol '__ksymtab_timekeeping_clocktai' was not declared. Should it be static?
> /git/linux/kernel/time/timekeeping.c:432:1: warning: symbol '__ksymtab_ktime_get_clocktai' was not declared. Should it be static?
> /git/linux/kernel/time/timekeeping.c:486:1: warning: symbol '__ksymtab_do_gettimeofday' was not declared. Should it be static?
> /git/linux/kernel/time/timekeeping.c:526:1: warning: symbol '__ksymtab_do_settimeofday' was not declared. Should it be static?
> /git/linux/kernel/time/timekeeping.c:570:1: warning: symbol '__ksymtab_timekeeping_inject_offset' was not declared. Should it be static?
> /git/linux/kernel/time/timekeeping.c:689:1: warning: symbol '__ksymtab_ktime_get_real' was not declared. Should it be static?
> /git/linux/kernel/time/timekeeping.c:712:1: warning: symbol '__ksymtab_getrawmonotonic' was not declared. Should it be static?
> /git/linux/kernel/time/timekeeping.c:1467:1: warning: symbol '__ksymtab_getboottime' was not declared. Should it be static?
> /git/linux/kernel/time/timekeeping.c:1500:1: warning: symbol '__ksymtab_get_monotonic_boottime' was not declared. Should it be static?
> /git/linux/kernel/time/timekeeping.c:1517:1: warning: symbol '__ksymtab_ktime_get_boottime' was not declared. Should it be static?
> /git/linux/kernel/time/timekeeping.c:1529:1: warning: symbol '__ksymtab_monotonic_to_bootbased' was not declared. Should it be static?
> /git/linux/kernel/time/timekeeping.c:1537:1: warning: symbol '__ksymtab_get_seconds' was not declared. Should it be static?
> /git/linux/kernel/time/timekeeping.c:1560:1: warning: symbol '__ksymtab_current_kernel_time' was not declared. Should it be static?
> /git/linux/kernel/time/timekeeping.c:1662:1: warning: symbol '__ksymtab_ktime_get_monotonic_offset' was not declared. Should it be static?
> "
>
> Any thoughts?
>
>
> Thanks,
> Wanlong Gao
>
>
>
> [1]
> commit e0f244c63fc9d192dfd399cc2677bbdca61994b1
> Author: Andi Kleen <ak@linux.intel.com>
> Date: Wed Oct 23 10:57:58 2013 +1030
>
> asmlinkage, module: Make ksymtab and kcrctab symbols and __this_module __visible
>
> Make the ksymtab symbols for EXPORT_SYMBOL visible.
> This prevents the LTO compiler from adding a .NUMBER prefix,
> which avoids various problems in later export processing.
>
> Cc: rusty@rustcorp.com.au
> Signed-off-by: Andi Kleen <ak@linux.intel.com>
> Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-sparse" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
>
>
prev parent reply other threads:[~2013-11-26 2:15 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-11-26 1:51 [BUG report] sparse warnings about "__ksymtab_*" symbols Wanlong Gao
2013-11-26 2:15 ` Wei Yongjun [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAPgLHd-WGDSeSg6By8ik1c26nBAw54wkL7NvZZwjR4O8y-Ho1g@mail.gmail.com \
--to=weiyj.lk@gmail.com \
--cc=ak@linux.intel.com \
--cc=fengguang.wu@intel.com \
--cc=gaowanlong@cn.fujitsu.com \
--cc=josh@kernel.org \
--cc=kbuild-all@01.org \
--cc=linux-sparse@vger.kernel.org \
--cc=rusty@rustcorp.com.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).