* [PATCH 3/8] integer_promotions() can't get SYM_NODE
@ 2007-07-13 17:44 Al Viro
2007-07-13 18:04 ` Josh Triplett
0 siblings, 1 reply; 2+ messages in thread
From: Al Viro @ 2007-07-13 17:44 UTC (permalink / raw)
To: linux-sparse
Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
---
evaluate.c | 9 ++-------
1 files changed, 2 insertions(+), 7 deletions(-)
diff --git a/evaluate.c b/evaluate.c
index 7669c9a..88435da 100644
--- a/evaluate.c
+++ b/evaluate.c
@@ -98,17 +98,12 @@ static struct symbol *evaluate_string(struct expression *expr)
return sym;
}
+/* type has come from classify_type and is an integer type */
static inline struct symbol *integer_promotion(struct symbol *type)
{
struct symbol *orig_type = type;
unsigned long mod = type->ctype.modifiers;
- int width;
-
- if (type->type == SYM_NODE)
- type = type->ctype.base_type;
- if (type->type == SYM_ENUM)
- type = type->ctype.base_type;
- width = type->bit_size;
+ int width = type->bit_size;
/*
* Bitfields always promote to the base type,
--
1.5.0-rc2.GIT
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [PATCH 3/8] integer_promotions() can't get SYM_NODE
2007-07-13 17:44 [PATCH 3/8] integer_promotions() can't get SYM_NODE Al Viro
@ 2007-07-13 18:04 ` Josh Triplett
0 siblings, 0 replies; 2+ messages in thread
From: Josh Triplett @ 2007-07-13 18:04 UTC (permalink / raw)
To: Al Viro; +Cc: linux-sparse
On Fri, 2007-07-13 at 18:44 +0100, Al Viro wrote:
> Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
> ---
> evaluate.c | 9 ++-------
> 1 files changed, 2 insertions(+), 7 deletions(-)
>
> diff --git a/evaluate.c b/evaluate.c
> index 7669c9a..88435da 100644
> --- a/evaluate.c
> +++ b/evaluate.c
> @@ -98,17 +98,12 @@ static struct symbol *evaluate_string(struct expression *expr)
> return sym;
> }
>
> +/* type has come from classify_type and is an integer type */
> static inline struct symbol *integer_promotion(struct symbol *type)
> {
> struct symbol *orig_type = type;
> unsigned long mod = type->ctype.modifiers;
> - int width;
> -
> - if (type->type == SYM_NODE)
> - type = type->ctype.base_type;
> - if (type->type == SYM_ENUM)
> - type = type->ctype.base_type;
> - width = type->bit_size;
> + int width = type->bit_size;
>
> /*
> * Bitfields always promote to the base type,
In addition to SYM_NODE as mentioned in the commit message, this also
removes SYM_ENUM as classify_type handles that too. I'll append that to
the commit message.
- Josh Triplett
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2007-07-13 18:04 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2007-07-13 17:44 [PATCH 3/8] integer_promotions() can't get SYM_NODE Al Viro
2007-07-13 18:04 ` Josh Triplett
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).