From: Linus Torvalds <torvalds@osdl.org>
To: Christopher Li <sparse@chrisli.org>
Cc: Yura Pakhuchiy <pakhuchiy@gmail.com>,
Josh Triplett <josh@freedesktop.org>,
linux-sparse@vger.kernel.org
Subject: Re: [PATCH][RFC] Re: sparse handles int64_t type wrong
Date: Wed, 13 Dec 2006 07:36:20 -0800 (PST) [thread overview]
Message-ID: <Pine.LNX.4.64.0612130733190.3418@woody.osdl.org> (raw)
In-Reply-To: <20061213051827.GA13748@chrisli.org>
On Tue, 12 Dec 2006, Christopher Li wrote:
>
> I took a stab at it. It seems that direct_declarator() does handle
> attributes, but it does not change the ctype to the declarator.
> It is kind of awkward that the type is already build when it hit
> the attribute in the end. It need to go back to overwrite
> the already parsed type.
Yes. I actually tried to fix this by moving the type "finalization" part
later, but it got really really nasty.
> I have this patch seems make the test case happy. I am not sure
> this is correct or not.
It looks correct to me, although not wonderfully pretty. But it's simpler
than the "don't do the int/fp type finalization until later" that I
couldn't even get to work (not that I spent a lot of time on it, but
still)
Linus
next prev parent reply other threads:[~2006-12-13 15:36 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-12-12 19:34 sparse handles int64_t type wrong Yura Pakhuchiy
2006-12-12 19:44 ` Linus Torvalds
2006-12-12 19:50 ` Yura Pakhuchiy
2006-12-12 20:02 ` Linus Torvalds
2006-12-12 20:25 ` Yura Pakhuchiy
2006-12-13 5:18 ` [PATCH][RFC] " Christopher Li
2006-12-13 15:36 ` Linus Torvalds [this message]
2006-12-14 0:13 ` Christopher Li
2006-12-14 0:57 ` Linus Torvalds
2006-12-14 4:21 ` Christopher Li
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Pine.LNX.4.64.0612130733190.3418@woody.osdl.org \
--to=torvalds@osdl.org \
--cc=josh@freedesktop.org \
--cc=linux-sparse@vger.kernel.org \
--cc=pakhuchiy@gmail.com \
--cc=sparse@chrisli.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).