From: Linus Torvalds <torvalds@linux-foundation.org>
To: Chris Li <sparse@chrisli.org>
Cc: Josh Triplett <josh@freedesktop.org>,
Linus Torvalds <torvalds@osdl.org>,
linux-sparse@vger.kernel.org
Subject: Re: [PATCH 5] Adding the NULL pointer checker.
Date: Mon, 29 Jan 2007 14:48:10 -0800 (PST) [thread overview]
Message-ID: <Pine.LNX.4.64.0701291446530.3611@woody.linux-foundation.org> (raw)
In-Reply-To: <70318cbf0701291430q629a9252r322ee4bb477d48b9@mail.gmail.com>
On Mon, 29 Jan 2007, Chris Li wrote:
> > > --- sparse.orig/expand.c 2007-01-16 11:13:18.000000000 -0800
> > > +++ sparse/expand.c 2007-01-16 11:13:28.000000000 -0800
> > > -#define SELECT_COST 20 /* Cut-off for turning a conditional
> > into a select */
> > > -#define BRANCH_COST 10 /* Cost of a conditional branch */
> > > +#define SELECT_COST 0 /* Cut-off for turning a conditional
> > into a select */
> > > +#define BRANCH_COST 0 /* Cost of a conditional branch */
> >
> > OK, I *think* that won't cause any harm.
>
> Linus, any words here? I have a vague impression that it has some thing to
> do with simplifying phi usage, but I am not sure what is the real side effect.
I just think the old costs are likely more realistic, but they were pulled
totally out of my *ss.
If it's more convenient to set them to zero, go wild. No deep meaning.
Linus
prev parent reply other threads:[~2007-01-29 22:48 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-01-17 2:39 [PATCH 5] Adding the NULL pointer checker Christopher Li
2007-01-17 2:41 ` Christopher Li
2007-01-27 8:20 ` Josh Triplett
2007-01-29 22:30 ` Chris Li
2007-01-29 22:48 ` Linus Torvalds [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Pine.LNX.4.64.0701291446530.3611@woody.linux-foundation.org \
--to=torvalds@linux-foundation.org \
--cc=josh@freedesktop.org \
--cc=linux-sparse@vger.kernel.org \
--cc=sparse@chrisli.org \
--cc=torvalds@osdl.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).