From: Conor Dooley <conor.dooley@microchip.com>
To: Palmer Dabbelt <palmer@rivosinc.com>
Cc: <luc.vanoostenryck@gmail.com>, <linux-sparse@vger.kernel.org>
Subject: Re: [PATCH] RISC-V: Add support for the zicbom extension
Date: Fri, 12 Aug 2022 09:25:23 +0100 [thread overview]
Message-ID: <YvYOc9Mk8y1dFvnp@wendy> (raw)
In-Reply-To: <20220811033138.20676-1-palmer@rivosinc.com>
On Wed, Aug 10, 2022 at 08:31:38PM -0700, Palmer Dabbelt wrote:
> This was recently added to binutils and with any luck will soon be in
> Linux, without it sparse will fail when trying to build new kernels on
> systems with new toolchains.
>
In passing while testing the zihintpause one:
Tested-by: Conor Dooley <conor.dooley@microchip.com>
> Signed-off-by: Palmer Dabbelt <palmer@rivosinc.com>
> ---
> target-riscv.c | 4 ++++
> 1 file changed, 4 insertions(+)
>
> diff --git a/target-riscv.c b/target-riscv.c
> index 217ab7e8..db0f7e57 100644
> --- a/target-riscv.c
> +++ b/target-riscv.c
> @@ -19,6 +19,7 @@
> #define RISCV_GENERIC (RISCV_MUL|RISCV_DIV|RISCV_ATOMIC|RISCV_FPU)
> #define RISCV_ZICSR (1 << 10)
> #define RISCV_ZIFENCEI (1 << 11)
> +#define RISCV_ZICBOM (1 << 12)
>
> static unsigned int riscv_flags;
>
> @@ -41,6 +42,7 @@ static void parse_march_riscv(const char *arg)
> { "c", RISCV_COMP },
> { "_zicsr", RISCV_ZICSR },
> { "_zifencei", RISCV_ZIFENCEI },
> + { "_zicbom", RISCV_ZICBOM },
> };
> int i;
>
> @@ -131,6 +133,8 @@ static void predefine_riscv(const struct target *self)
> predefine("__riscv_zicsr", 1, "1");
> if (riscv_flags & RISCV_ZIFENCEI)
> predefine("__riscv_zifencei", 1, "1");
> + if (riscv_flags & RISCV_ZICBOM)
> + predefine("__riscv_zicbom", 1, "1");
>
> if (cmodel)
> predefine_strong("__riscv_cmodel_%s", cmodel);
> --
> 2.34.1
>
next prev parent reply other threads:[~2022-08-12 8:25 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-08-11 3:31 [PATCH] RISC-V: Add support for the zicbom extension Palmer Dabbelt
2022-08-12 8:25 ` Conor Dooley [this message]
2022-10-12 21:11 ` Conor Dooley
2022-10-12 23:34 ` Palmer Dabbelt
2022-10-13 11:34 ` Conor Dooley
2023-12-15 12:37 ` Geert Uytterhoeven
2023-12-18 13:58 ` Luc Van Oostenryck
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YvYOc9Mk8y1dFvnp@wendy \
--to=conor.dooley@microchip.com \
--cc=linux-sparse@vger.kernel.org \
--cc=luc.vanoostenryck@gmail.com \
--cc=palmer@rivosinc.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).