From: Paul Walmsley <pjw@kernel.org>
To: Ben Dooks <ben.dooks@codethink.co.uk>
Cc: linux-sparse@vger.kernel.org
Subject: Re: [PATCH 2/2] RISC-V: restart extension search on match
Date: Wed, 7 Jan 2026 13:42:24 -0700 (MST) [thread overview]
Message-ID: <a273a46c-c90b-3895-c019-09a624ba43a4@kernel.org> (raw)
In-Reply-To: <20260102114449.535597-3-ben.dooks@codethink.co.uk>
On Fri, 2 Jan 2026, Ben Dooks wrote:
> If we are passed multiple extensions in -march, don't assume these will
> be in any sort of order. If we do match, then restart the loop by setting
> the search back to 0, and retrying.
>
> This sorts out issues with the current kernel build where there are now
> lots of extensions for the rv64i and even adding zacas doesn't silence the
> warnings generated.
>
> Signed-off-by: Ben Dooks <ben.dooks@codethink.co.uk>
> ---
> target-riscv.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/target-riscv.c b/target-riscv.c
> index 80c25285..ddf50e61 100644
> --- a/target-riscv.c
> +++ b/target-riscv.c
> @@ -56,7 +56,7 @@ static void parse_march_riscv(const char *arg)
>
> // Each -march=.. options entirely overrides previous ones
> riscv_flags = 0;
> -
> +
Looks like some horizontal whitespace was inadvertently added here.
> for (i = 0; i < ARRAY_SIZE(basic_sets); i++) {
> const char *pat = basic_sets[i].pattern;
> size_t len = strlen(pat);
> @@ -80,6 +80,7 @@ ext:
> if (!strncmp(arg, pat, len)) {
> riscv_flags |= extensions[i].flags;
> arg += len;
> + i = 0;
> }
> }
> if (arg[0])
Tested-by: Paul Walmsley <pjw@kernel.org>
- Paul
prev parent reply other threads:[~2026-01-07 20:42 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-01-02 11:44 Two updates for RISC-V -march warnings Ben Dooks
2026-01-02 11:44 ` [PATCH 1/2] RISC-V: Stop warning about Zabha and Zacas Ben Dooks
2026-01-07 20:41 ` Paul Walmsley
2026-01-02 11:44 ` [PATCH 2/2] RISC-V: restart extension search on match Ben Dooks
2026-01-07 20:42 ` Paul Walmsley [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a273a46c-c90b-3895-c019-09a624ba43a4@kernel.org \
--to=pjw@kernel.org \
--cc=ben.dooks@codethink.co.uk \
--cc=linux-sparse@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox