From: Oleg Nesterov <oleg@redhat.com>
To: Chris Li <sparse@chrisli.org>, Luc Van Oostenryck <lucvoo@kernel.org>
Cc: Alexey Gladkov <legion@kernel.org>, linux-sparse@vger.kernel.org
Subject: [PATCH 1/2] sparse/semind: add the new --param=dissect-show-compiled option
Date: Fri, 26 Dec 2025 15:31:56 +0100 [thread overview]
Message-ID: <aU6cXFyfwtD9GMYa@redhat.com> (raw)
parse_cmdline_add() sets dissect_show_all_symbols = 1 unconditionally
and currently it is not possible to clear this option.
We could simply remove this line; users could use
"semind add --param=dissect-show-all-symbols," but this would break
existing setups.
Signed-off-by: Oleg Nesterov <oleg@redhat.com>
---
options.c | 2 ++
semind.c | 4 ++--
2 files changed, 4 insertions(+), 2 deletions(-)
diff --git a/options.c b/options.c
index 0f207e80..dbe0349f 100644
--- a/options.c
+++ b/options.c
@@ -976,6 +976,8 @@ static char **handle_param(char *arg, char **next)
if (!strcmp(value, "dissect-show-all-symbols"))
dissect_show_all_symbols = 1;
+ else if (!strcmp(value, "dissect-show-compiled"))
+ dissect_show_all_symbols = 0;
return next;
}
diff --git a/semind.c b/semind.c
index ad8003ba..fa084e04 100644
--- a/semind.c
+++ b/semind.c
@@ -322,14 +322,14 @@ done:
show_usage();
}
- // enforce tabstop
+ // enforce defaults
tabstop = 1;
+ dissect_show_all_symbols = 1;
// step back since sparse_initialize will ignore argv[0].
optind--;
sparse_initialize(argc - optind, argv + optind, &semind_filelist);
- dissect_show_all_symbols = 1;
}
static void parse_cmdline_rm(int argc, char **argv)
--
2.52.0
next reply other threads:[~2025-12-26 14:32 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-12-26 14:31 Oleg Nesterov [this message]
2025-12-26 14:32 ` [PATCH 2/2] sparse/semind: robustify parse_cmdline_add() Oleg Nesterov
2025-12-27 15:58 ` Alexey Gladkov
2025-12-27 15:58 ` [PATCH 1/2] sparse/semind: add the new --param=dissect-show-compiled option Alexey Gladkov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aU6cXFyfwtD9GMYa@redhat.com \
--to=oleg@redhat.com \
--cc=legion@kernel.org \
--cc=linux-sparse@vger.kernel.org \
--cc=lucvoo@kernel.org \
--cc=sparse@chrisli.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).