From mboxrd@z Thu Jan 1 00:00:00 1970 From: bugzilla-daemon@bugzilla.kernel.org Subject: [Bug 207959] Don't warn about the universal zero initializer for a structure with the 'designated_init' attribute. Date: Thu, 28 May 2020 22:31:58 +0000 Message-ID: References: Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8BIT Return-path: Received: from mail.kernel.org ([198.145.29.99]:34200 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2436803AbgE1Wb7 (ORCPT ); Thu, 28 May 2020 18:31:59 -0400 In-Reply-To: Sender: linux-sparse-owner@vger.kernel.org List-Id: linux-sparse@vger.kernel.org To: linux-sparse@vger.kernel.org https://bugzilla.kernel.org/show_bug.cgi?id=207959 Linus Torvalds (torvalds@linux-foundation.org) changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |torvalds@linux-foundation.o | |rg --- Comment #5 from Linus Torvalds (torvalds@linux-foundation.org) --- That said, I'm not sure the kernel cares. If sparse makes '{ 0 }' be eqivalent to '{ }' and doesn't warn for it, it's not like it's a huge deal. The problem with using 0 instead of NULL (or vice versa, which is a crime, and which is why NULL should never have been defined to plain 0) comes when it is actually confusing. For something like a silly zero struct initializer it's not like it's the end of the world. I do find the whole "0 could be a pointer, and NULL could be used for an integer or float" to be very distasteful, and the C++ people in particular were in denial about their brokenness for much much too long. So I'd prefer the "0 for NULL" warning, even if this may not be the most important case for it. -- You are receiving this mail because: You are watching the assignee of the bug.