Linux SPARSE checker discussions
 help / color / mirror / Atom feed
From: Ramsay Jones <ramsay@ramsayjones.plus.com>
To: Luc Van Oostenryck <luc.vanoostenryck@gmail.com>
Cc: linux-sparse@vger.kernel.org
Subject: Re: multiarch & base dir
Date: Sun, 5 Nov 2017 18:50:22 +0000	[thread overview]
Message-ID: <ddd46aa0-8dbb-e644-ec46-56b235727438@ramsayjones.plus.com> (raw)
In-Reply-To: <20171105093301.adsucwshznehtdr4@ltop.local>



On 05/11/17 09:33, Luc Van Oostenryck wrote:
> Hi,
> 
> Commit 85e2e2a25 "Add support for multiarch system header files"
> added for GCC's multiarch directory. One of the change was :
> +       /* add the multiarch include directories, if any */
> +       if (multiarch_dir && *multiarch_dir) {
> +               add_pre_buffer("#add_system \"/usr/include/%s\"\n", multiarch_dir);
> +               add_pre_buffer("#add_system \"/usr/local/include/%s\"\n", multiarch_dir);
> +       }
> 
> 
> There, the multiarch dir is appended to /usr/include & /usr/local/include.
> I'm wondering if using GCC_BASE should be used here instead.
> Any thoughts?

My initial reaction is definitely not! Certainly not _instead_ of
/usr/include and /usr/local/include. Adding GCC_BASE, which would
look something like: '/usr/lib/gcc/x86_64-linux-gnu/5', does not
immediately strike me as a good idea, but I haven't given it much
thought. ;-)

ATB,
Ramsay Jones


  parent reply	other threads:[~2017-11-05 18:57 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-11-05  9:33 multiarch & base dir Luc Van Oostenryck
2017-11-05  9:59 ` Christopher Li
2017-11-05 10:08   ` Luc Van Oostenryck
2017-11-05 18:50 ` Ramsay Jones [this message]
2017-11-05 20:01   ` Luc Van Oostenryck

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ddd46aa0-8dbb-e644-ec46-56b235727438@ramsayjones.plus.com \
    --to=ramsay@ramsayjones.plus.com \
    --cc=linux-sparse@vger.kernel.org \
    --cc=luc.vanoostenryck@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox