unable to open limits.h

unable to open limits.h

[Christoph Hellwig]

On Ubuntu 8.10 (glibc 2.8.90) I get the following warnings when
compiling any program using limits.h:

/usr/include/limits.h:125:17: error: unable to open 'limits.h'

The easiest testcase is:

cat > test.c  << EOF
#include <limits.h>
EOF
cgcc -c test.c 

Re: unable to open limits.h

[Alexey Zaytsev]

On Tue, Nov 25, 2008 at 14:07, Christoph Hellwig <hch@infradead.org> wrote:
> On Ubuntu 8.10 (glibc 2.8.90) I get the following warnings when
> compiling any program using limits.h:
>
> /usr/include/limits.h:125:17: error: unable to open 'limits.h'

This is probably fixed by
http://git.zaytsev.su/git?p=sparse.git;a=commitdiff;h=6f089b22a222dd086d14c985c5a67f8b3afd2177

Josh, please pull the gsoc2008-up branch from git://zaytsev.su/git/sparse.git

Re: unable to open limits.h

[Sam Ravnborg]

On Tue, Nov 25, 2008 at 03:18:58PM +0300, Alexey Zaytsev wrote:
> On Tue, Nov 25, 2008 at 14:07, Christoph Hellwig <hch@infradead.org> wrote:
> > On Ubuntu 8.10 (glibc 2.8.90) I get the following warnings when
> > compiling any program using limits.h:
> >
> > /usr/include/limits.h:125:17: error: unable to open 'limits.h'
> 
> This is probably fixed by
> http://git.zaytsev.su/git?p=sparse.git;a=commitdiff;h=6f089b22a222dd086d14c985c5a67f8b3afd2177

Is this the right fix?
We should not rely on that sparse is built with the same gcc as currently installed.

The fix should be that we automagically uses the right path which
is available on the system.

> 
> Josh, please pull the gsoc2008-up branch from git://zaytsev.su/git/sparse.git
For a pull request itis prefarable that you always include:
- diffstat
- shortlog
- short intor what is contained

I assume patches has been on sparse ml.


	Sam

Re: unable to open limits.h

[Christoph Hellwig]

On Tue, Nov 25, 2008 at 03:18:58PM +0300, Alexey Zaytsev wrote:
> On Tue, Nov 25, 2008 at 14:07, Christoph Hellwig <hch@infradead.org> wrote:
> > On Ubuntu 8.10 (glibc 2.8.90) I get the following warnings when
> > compiling any program using limits.h:
> >
> > /usr/include/limits.h:125:17: error: unable to open 'limits.h'
> 
> This is probably fixed by
> http://git.zaytsev.su/git?p=sparse.git;a=commitdiff;h=6f089b22a222dd086d14c985c5a67f8b3afd2177
> 
> Josh, please pull the gsoc2008-up branch from git://zaytsev.su/git/sparse.git

I still see the error with a sparse built from your repository.

Re: unable to open limits.h

[Christoph Hellwig]

On Tue, Nov 25, 2008 at 07:36:22AM -0500, Christoph Hellwig wrote:
> On Tue, Nov 25, 2008 at 03:18:58PM +0300, Alexey Zaytsev wrote:
> > On Tue, Nov 25, 2008 at 14:07, Christoph Hellwig <hch@infradead.org> wrote:
> > > On Ubuntu 8.10 (glibc 2.8.90) I get the following warnings when
> > > compiling any program using limits.h:
> > >
> > > /usr/include/limits.h:125:17: error: unable to open 'limits.h'
> > 
> > This is probably fixed by
> > http://git.zaytsev.su/git?p=sparse.git;a=commitdiff;h=6f089b22a222dd086d14c985c5a67f8b3afd2177
> > 
> > Josh, please pull the gsoc2008-up branch from git://zaytsev.su/git/sparse.git
> 
> I still see the error with a sparse built from your repository.

Oh, looks like your have the change in some bloody branch.  Care to send
a patch or publish a proper repository?

Re: unable to open limits.h

[Alexey Zaytsev]

On Tue, Nov 25, 2008 at 15:27, Sam Ravnborg <sam@ravnborg.org> wrote:
> On Tue, Nov 25, 2008 at 03:18:58PM +0300, Alexey Zaytsev wrote:
>> On Tue, Nov 25, 2008 at 14:07, Christoph Hellwig <hch@infradead.org> wrote:
>> > On Ubuntu 8.10 (glibc 2.8.90) I get the following warnings when
>> > compiling any program using limits.h:
>> >
>> > /usr/include/limits.h:125:17: error: unable to open 'limits.h'
>>
>> This is probably fixed by
>> http://git.zaytsev.su/git?p=sparse.git;a=commitdiff;h=6f089b22a222dd086d14c985c5a67f8b3afd2177
>
> Is this the right fix?
> We should not rely on that sparse is built with the same gcc as currently installed.
>
> The fix should be that we automagically uses the right path which
> is available on the system.
>
I see no magic way to find the right path, except specifying which gcc version
sparse would have to follow. Probably cgcc could pass it to sparse, but anyway,
this would probably be an other patch. Mine does not change the way
sparse works,
only adds the new include dir, which should not harm the

>>
>> Josh, please pull the gsoc2008-up branch from git://zaytsev.su/git/sparse.git
> For a pull request itis prefarable that you always include:
> - diffstat
> - shortlog
> - short intor what is contained

The branch contains cleanups and other straight-forward changes gained as as a
side-effect of my sparse linker work this summer. Josh has already agreed on the
patches, but was too busy and pobably forgot to pull. Anyway, there is
the shortlog:

Alexey Zaytsev (9):
      Make show_symbol newline-consistent
      Looks more evident this way.
      Handle a terminal -o option properly.
      Mark handle_switch as static and don't export it from lib.h
      Handle missing argument to -D.
      Gdb macros to get a better look at some sparse data structures.
      A slightly edited irc discussion with Josh Triplett.
      Add $GCC_BASE/include-fixed to the include list.
      Warning should be enough for an unhandled transparent union

The patches seem to be too trivial to discuss. For the non-trivial
patches from the
gsoc2008-linker branch I got constructive feedback and will probably
rework the idea.

Re: unable to open limits.h

[Alexey Zaytsev]

On Tue, Nov 25, 2008 at 15:37, Christoph Hellwig <hch@infradead.org> wrote:
> On Tue, Nov 25, 2008 at 07:36:22AM -0500, Christoph Hellwig wrote:
>> On Tue, Nov 25, 2008 at 03:18:58PM +0300, Alexey Zaytsev wrote:
>> > On Tue, Nov 25, 2008 at 14:07, Christoph Hellwig <hch@infradead.org> wrote:
>> > > On Ubuntu 8.10 (glibc 2.8.90) I get the following warnings when
>> > > compiling any program using limits.h:
>> > >
>> > > /usr/include/limits.h:125:17: error: unable to open 'limits.h'
>> >
>> > This is probably fixed by
>> > http://git.zaytsev.su/git?p=sparse.git;a=commitdiff;h=6f089b22a222dd086d14c985c5a67f8b3afd2177
>> >
>> > Josh, please pull the gsoc2008-up branch from git://zaytsev.su/git/sparse.git
>>
>> I still see the error with a sparse built from your repository.
>
> Oh, looks like your have the change in some bloody branch.  Care to send
> a patch or publish a proper repository?
>
Yes, the commit is located in the gsoc2008-up branch, but you've probably
already found it by the time. ;)