[PATCH 0/2] Fix sparc64 and x86_64 issues

[PATCH 0/2] Fix sparc64 and x86_64 issues

[Blue Swirl]

Hi,

With these patches, I can run Sparse on OpenBIOS sources (which use
libgcc) also when compiling for 64 bit targets. 64 bit targets use 128
bit double cells, just like 64 bit double cells are used on 32 bit
targets.

I'm not sure if 'long long long' is actually used, libgcc uses
__attribute__ ((mode (TI))).

Blue Swirl (2):
  Add support for TImode type (__int128_t)
  Define __LP64__ for x86_64 unless in 32 bit mode

 cgcc         |    9 +++++----
 evaluate.c   |    8 +++++---
 expand.c     |    3 ++-
 gdbhelpers   |    3 +++
 parse.c      |   25 ++++++++++++++++++++++---
 show-parse.c |    3 +++
 symbol.c     |    6 ++++++
 symbol.h     |    8 +++++---
 target.c     |    1 +
 target.h     |    1 +
 10 files changed, 53 insertions(+), 14 deletions(-)

Re: [PATCH 0/2] Fix sparc64 and x86_64 issues

[Blue Swirl]

[-- Attachment #1: Type: text/plain, Size: 1081 bytes --]

On Wed, Aug 5, 2009 at 9:51 PM, Blue Swirl<blauwirbel@gmail.com> wrote:
> Hi,
>
> With these patches, I can run Sparse on OpenBIOS sources (which use
> libgcc) also when compiling for 64 bit targets. 64 bit targets use 128
> bit double cells, just like 64 bit double cells are used on 32 bit
> targets.
>
> I'm not sure if 'long long long' is actually used, libgcc uses
> __attribute__ ((mode (TI))).
>
> Blue Swirl (2):
>  Add support for TImode type (__int128_t)
>  Define __LP64__ for x86_64 unless in 32 bit mode
>
>  cgcc         |    9 +++++----
>  evaluate.c   |    8 +++++---
>  expand.c     |    3 ++-
>  gdbhelpers   |    3 +++
>  parse.c      |   25 ++++++++++++++++++++++---
>  show-parse.c |    3 +++
>  symbol.c     |    6 ++++++
>  symbol.h     |    8 +++++---
>  target.c     |    1 +
>  target.h     |    1 +
>  10 files changed, 53 insertions(+), 14 deletions(-)
>

There was a bug in the 128 bit constant in cgcc, I forgot to subtract
one. Here are updated patches as attachments.

[-- Attachment #2: 0001-Add-support-for-TImode-type-__int128_t.patch --]
[-- Type: application/mbox, Size: 11274 bytes --]

[-- Attachment #3: 0002-Define-__LP64__-for-x86_64-unless-in-32-bit-mode.patch --]
[-- Type: application/mbox, Size: 913 bytes --]

Re: [PATCH 0/2] Fix sparc64 and x86_64 issues

[Christopher Li]

On Thu, Aug 6, 2009 at 1:23 PM, Blue Swirl<blauwirbel@gmail.com> wrote:
> On Wed, Aug 5, 2009 at 9:51 PM, Blue Swirl<blauwirbel@gmail.com> wrote:
>> Hi,
>>
>> With these patches, I can run Sparse on OpenBIOS sources (which use
>> libgcc) also when compiling for 64 bit targets. 64 bit targets use 128
>> bit double cells, just like 64 bit double cells are used on 32 bit
>> targets.
>>
>> I'm not sure if 'long long long' is actually used, libgcc uses
>> __attribute__ ((mode (TI))).

The change looks reasonable.

I feel that we can use:

#define MOD_ALL_LONG (MOD_LONG | MOD_LONGLONG | MOD_LONGLONGLONG)

Eventually the expression needs to handle 128 bit long constant as well.

Chris

Re: [PATCH 0/2] Fix sparc64 and x86_64 issues

[Christopher Li]

On Thu, Aug 6, 2009 at 2:16 PM, Christopher Li<sparse@chrisli.org> wrote:
> On Thu, Aug 6, 2009 at 1:23 PM, Blue Swirl<blauwirbel@gmail.com> wrote:
>> On Wed, Aug 5, 2009 at 9:51 PM, Blue Swirl<blauwirbel@gmail.com> wrote:
>>> Hi,
>>>
>>> With these patches, I can run Sparse on OpenBIOS sources (which use
>>> libgcc) also when compiling for 64 bit targets. 64 bit targets use 128
>>> bit double cells, just like 64 bit double cells are used on 32 bit
>>> targets.
>>>
>>> I'm not sure if 'long long long' is actually used, libgcc uses
>>> __attribute__ ((mode (TI))).
>
> The change looks reasonable.
>
> I feel that we can use:
>
> #define MOD_ALL_LONG (MOD_LONG | MOD_LONGLONG | MOD_LONGLONGLONG)
>

I push the change does that. Please verify.

Thanks

Chris

Re: [PATCH 0/2] Fix sparc64 and x86_64 issues

[Blue Swirl]

On Mon, Aug 10, 2009 at 8:49 PM, Christopher Li<sparse@chrisli.org> wrote:
> On Thu, Aug 6, 2009 at 2:16 PM, Christopher Li<sparse@chrisli.org> wrote:
>> On Thu, Aug 6, 2009 at 1:23 PM, Blue Swirl<blauwirbel@gmail.com> wrote:
>>> On Wed, Aug 5, 2009 at 9:51 PM, Blue Swirl<blauwirbel@gmail.com> wrote:
>>>> Hi,
>>>>
>>>> With these patches, I can run Sparse on OpenBIOS sources (which use
>>>> libgcc) also when compiling for 64 bit targets. 64 bit targets use 128
>>>> bit double cells, just like 64 bit double cells are used on 32 bit
>>>> targets.
>>>>
>>>> I'm not sure if 'long long long' is actually used, libgcc uses
>>>> __attribute__ ((mode (TI))).
>>
>> The change looks reasonable.
>>
>> I feel that we can use:
>>
>> #define MOD_ALL_LONG (MOD_LONG | MOD_LONGLONG | MOD_LONGLONGLONG)
>>
>
> I push the change does that. Please verify.

Seems to work, thanks!