From: Krzysztof Halasa <khc@pm.waw.pl>
To: Josh Triplett <josht@linux.vnet.ibm.com>
Cc: Andrew Morton <akpm@linux-foundation.org>,
linux-kernel@vger.kernel.org,
Linus Torvalds <torvalds@linux-foundation.org>,
linux-sparse@vger.kernel.org
Subject: Re: [PATCH] CodingStyle: proscribe do-while without braces.
Date: Fri, 27 Jul 2007 19:44:41 +0200 [thread overview]
Message-ID: <m3r6mt4u7q.fsf@maximus.localdomain> (raw)
In-Reply-To: <1185555916.2642.8.camel@josh-work.beaverton.ibm.com> (Josh Triplett's message of "Fri, 27 Jul 2007 10:05:16 -0700")
Josh Triplett <josht@linux.vnet.ibm.com> writes:
> Perhaps, but
> 1. Existing kernel style uses braces with single-statement
> do-while.
> 2. Linus prefers (or at least preferred in October of 2006) braces
> with single-statement do-while.
Fine with me, but it should IMHO be maintainer's call.
Things which a) are clearly better, and/or b) would require massive
reformatting when new maintainer steps in, should be documented
in CodingStyle and perhaps checked for by scripts and sparse.
Other things... sometimes there are multiple ways to do something
well, and humans aren't, and shouldn't be that deterministic.
--
Krzysztof Halasa
next prev parent reply other threads:[~2007-07-27 17:44 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-07-26 21:37 [PATCH] CodingStyle: proscribe do-while without braces Josh Triplett
2007-07-26 21:44 ` Andrew Morton
2007-07-26 21:54 ` Josh Triplett
2007-07-27 0:18 ` Krzysztof Halasa
2007-07-27 0:35 ` Andrew Morton
2007-07-27 16:00 ` Krzysztof Halasa
2007-07-27 17:05 ` Josh Triplett
2007-07-27 17:44 ` Krzysztof Halasa [this message]
2007-07-27 18:27 ` Andrew Morton
2007-07-27 18:52 ` Josh Triplett
2007-07-27 0:42 ` Stefan Richter
2007-07-27 0:59 ` Andrew Morton
2007-07-27 7:41 ` Stefan Richter
2007-07-27 7:53 ` Andrew Morton
2007-07-27 17:13 ` Stefan Richter
2007-07-27 1:17 ` Randy Dunlap
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=m3r6mt4u7q.fsf@maximus.localdomain \
--to=khc@pm.waw.pl \
--cc=akpm@linux-foundation.org \
--cc=josht@linux.vnet.ibm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-sparse@vger.kernel.org \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox