From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 31CF4C433F5 for ; Fri, 21 Jan 2022 18:22:21 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1382085AbiAUSWU (ORCPT ); Fri, 21 Jan 2022 13:22:20 -0500 Received: from gate.crashing.org ([63.228.1.57]:52980 "EHLO gate.crashing.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1382087AbiAUSWS (ORCPT ); Fri, 21 Jan 2022 13:22:18 -0500 Received: from gate.crashing.org (localhost.localdomain [127.0.0.1]) by gate.crashing.org (8.14.1/8.14.1) with ESMTP id 20LIFjdK029046; Fri, 21 Jan 2022 12:15:45 -0600 Received: (from segher@localhost) by gate.crashing.org (8.14.1/8.14.1/Submit) id 20LIFiiO029045; Fri, 21 Jan 2022 12:15:44 -0600 X-Authentication-Warning: gate.crashing.org: segher set sender to segher@kernel.crashing.org using -f Date: Fri, 21 Jan 2022 12:15:44 -0600 From: Segher Boessenkool To: Greg Kroah-Hartman Cc: Christophe Leroy , "linux-kernel@vger.kernel.org" , Paul Mackerras , "linux-spdx@vger.kernel.org" , Thomas Gleixner , "linuxppc-dev@lists.ozlabs.org" Subject: Re: [PATCH v3] powerpc: Add missing SPDX license identifiers Message-ID: <20220121181544.GH614@gate.crashing.org> References: <24829c2f-6855-c8d6-7ae4-17c5517f890d@csgroup.eu> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.4.2.3i Precedence: bulk List-ID: X-Mailing-List: linux-spdx@vger.kernel.org On Fri, Jan 21, 2022 at 04:19:12PM +0100, Greg Kroah-Hartman wrote: > On Fri, Jan 21, 2022 at 03:13:50PM +0000, Christophe Leroy wrote: > > >> - * This file is free software; you can redistribute it and/or modify it > > >> - * under the terms of the GNU General Public License as published by the > > >> - * Free Software Foundation; either version 2, or (at your option) any > > >> - * later version. [ ... ] > > >> * As a special exception, if you link this library with files > > >> * compiled with GCC to produce an executable, this does not cause > > >> * the resulting executable to be covered by the GNU General Public License. The "as a special exception" refers to "This file is free software; you can redistribute it and/or modify it". It is meaningless without having anything it is an exception *to* :-) In general, you should never edit licence texts. > > > Look at that "special exception", why are you ignoring it here? You > > > can't do that :( > > > > I'm not ignoring it, that's the reason why I left it. > > You ignore that part of the license in the SPDX line, why? > > > Isn't it the correct way to do ? How should it be done ? > > You need to properly describe this in the SPDX line. You did not do so > here, which means that any tool just looking at the SPDX line would get > this license wrong. A new label needs to be defined and documented. Should be pretty mechanical to do, but that should see a wider audience than the powerpc hackers :-) Segher