public inbox for linux-spdx@vger.kernel.org
 help / color / mirror / Atom feed
From: Peter Zijlstra <peterz@infradead.org>
To: Tim Bird <tim.bird@sony.com>
Cc: rusty@rustcorp.com.au, greg@kroah.com, tglx@kernel.org,
	linux-spdx@vger.kernel.org, linux-kernel@vger.kernel.org,
	Tim Bird <tbird20d@yahoo.com>
Subject: Re: [PATCH] kernel: adjust cpu.c SPDX id
Date: Wed, 28 Jan 2026 21:39:23 +0100	[thread overview]
Message-ID: <20260128203923.GX166857@noisy.programming.kicks-ass.net> (raw)
In-Reply-To: <20260128200433.1221228-1-tim.bird@sony.com>

On Wed, Jan 28, 2026 at 01:04:33PM -0700, Tim Bird wrote:
> From: Tim Bird <tbird20d@yahoo.com>
> 
> Rusty Russell's intent was to have his files licensed as
> GPL-2.0-or-later.  Reflect that intent by adjusting the
> SPDX-License-Identifier line for cpu.c
> 
> Signed-off-by: Tim Bird <tbird20d@yahoo.com>
> Link: https://lore.kernel.org/linux-spdx/875x8yw4n6.fsf@rustcorp.com.au/
> ---
>  kernel/cpu.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/kernel/cpu.c b/kernel/cpu.c
> index 5185c0be847a0..a7a1cf8ea8e08 100644
> --- a/kernel/cpu.c
> +++ b/kernel/cpu.c
> @@ -1,4 +1,4 @@
> -// SPDX-License-Identifier: GPL-2.0
> +// SPDX-License-Identifier: GPL-2.0-or-later
>  /* CPU control.
>   * (C) 2001, 2002, 2003, 2004 Rusty Russell
>   */

While seeing this fly by (and I really don't care too deeply), I did
make me wonder to the purpose and efficacy of the SPDX header itself.

That is; while Rusty prefers GPL2+, not many of the actual lines in that
file are actually still authored by him. What if those authors prefer
something else?

That is, why are we accounting copyright per file, rather than per
author or even commit (git-blame FTW and all).

Most of the current lines (by a fair margin) seem to belong to Thomas,
so lets throw him under the bus and ponder the hypothetical that he very
strongly prefers GPL2 rather than GPL2+, how does the SPDX header make
sense?

  reply	other threads:[~2026-01-28 20:39 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-01-13 23:44 [PATCH] kernel: add SPDX-License-Identifier lines Tim Bird
2026-01-14 15:24 ` Karim Yaghmour
2026-01-19  5:30 ` Rusty Russell
2026-01-19 19:41   ` Bird, Tim
2026-01-19 22:40 ` [PATCH v2] kernel: Add " Tim Bird
2026-01-27 14:57   ` Greg KH
2026-01-27 15:05     ` Bird, Tim
2026-01-28 20:04 ` [PATCH] kernel: adjust cpu.c SPDX id Tim Bird
2026-01-28 20:39   ` Peter Zijlstra [this message]
2026-01-29 16:28     ` Bird, Tim

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260128203923.GX166857@noisy.programming.kicks-ass.net \
    --to=peterz@infradead.org \
    --cc=greg@kroah.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-spdx@vger.kernel.org \
    --cc=rusty@rustcorp.com.au \
    --cc=tbird20d@yahoo.com \
    --cc=tglx@kernel.org \
    --cc=tim.bird@sony.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox