From: Tim Bird <tim.bird@sony.com>
To: apw@canonical.com, joe@perches.com, dwaipayanray1@gmail.com,
lukas.bulwahn@gmail.com
Cc: linux-spdx@vger.kernel.org, linux-kernel@vger.kernel.org,
Tim Bird <tim.bird@sony.com>
Subject: [PATCH] checkpatch: add check for missing */ in spdx line
Date: Wed, 4 Feb 2026 14:38:23 -0700 [thread overview]
Message-ID: <20260204213823.1754560-1-tim.bird@sony.com> (raw)
Add an explicit check for leading /* but missing */
to avoid a malformed SPDX line.
In many cases an SPDX-License-Identifier line immediately
precedes another C-style comment. In that case, if
the SPDX line starts with '/*' but is missing the closing '*/',
the compiler may not catch it (the leading '/*' on
the next line and the rest of the header comment is just
treated as part of the SPDX comment).
Signed-off-by: Tim Bird <tim.bird@sony.com>
---
scripts/checkpatch.pl | 5 +++++
1 file changed, 5 insertions(+)
diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl
index c0250244cf7a..1cc3fd5e72af 100755
--- a/scripts/checkpatch.pl
+++ b/scripts/checkpatch.pl
@@ -3794,6 +3794,11 @@ sub process {
WARN("SPDX_LICENSE_TAG",
"Improper SPDX comment style for '$realfile', please use '$comment' instead\n" . $herecurr);
}
+ if ($comment eq '/*' &&
+ $rawline !~ m@\*/@) {
+ WARN("SPDX_LICENSE_TAG",
+ "Improper SPDX comment style for '$realfile', missing closing '*/'\n" . $herecurr);
+ }
if ($comment !~ /^$/ &&
$rawline !~ m@^\+\Q$comment\E SPDX-License-Identifier: @) {
--
2.43.0
next reply other threads:[~2026-02-04 21:38 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-02-04 21:38 Tim Bird [this message]
2026-02-04 22:21 ` [PATCH] checkpatch: add check for missing */ in spdx line Joe Perches
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260204213823.1754560-1-tim.bird@sony.com \
--to=tim.bird@sony.com \
--cc=apw@canonical.com \
--cc=dwaipayanray1@gmail.com \
--cc=joe@perches.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-spdx@vger.kernel.org \
--cc=lukas.bulwahn@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox