[PATCH v2] ALSA: usb-audio: Add SPDX id to midi.c

[PATCH v2] ALSA: usb-audio: Add SPDX id to midi.c

[Tim Bird]

Add an SPDX-License-Identifier line to sound/usb/midi.c
Use 'BSD-Source-Code' as part of the OR for the
license id.

Signed-off-by: Tim Bird <tim.bird@sony.com>
---
This patch depends on the one for opl4 sound driver, as that
one adds the BSD-Source-Code license for the LICENSES directory.

V1 -> V2
 - Change to use BSD-Source-Code, from the weird LicenseRef variant
   thing I was doing before.  This is a supported SPDX ID.
 - Use better subject prefix (ALSA: usb-audio:)
---
 sound/usb/midi.c | 27 +--------------------------
 1 file changed, 1 insertion(+), 26 deletions(-)

diff --git a/sound/usb/midi.c b/sound/usb/midi.c
index dd8249e75970..e6e8618a232a 100644
--- a/sound/usb/midi.c
+++ b/sound/usb/midi.c
@@ -1,3 +1,4 @@
+// SPDX-License-Identifier: GPL-2.0-or-later OR BSD-Source-Code
 /*
  * usbmidi.c - ALSA USB MIDI driver
  *
@@ -7,32 +8,6 @@
  * Based on the OSS usb-midi driver by NAGANO Daisuke,
  *          NetBSD's umidi driver by Takuya SHIOZAKI,
  *          the "USB Device Class Definition for MIDI Devices" by Roland
- *
- * Redistribution and use in source and binary forms, with or without
- * modification, are permitted provided that the following conditions
- * are met:
- * 1. Redistributions of source code must retain the above copyright
- *    notice, this list of conditions, and the following disclaimer,
- *    without modification.
- * 2. The name of the author may not be used to endorse or promote products
- *    derived from this software without specific prior written permission.
- *
- * Alternatively, this software may be distributed and/or modified under the
- * terms of the GNU General Public License as published by the Free Software
- * Foundation; either version 2 of the License, or (at your option) any later
- * version.
- *
- * THIS SOFTWARE IS PROVIDED BY THE AUTHOR AND CONTRIBUTORS ``AS IS'' AND
- * ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE
- * IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR PURPOSE
- * ARE DISCLAIMED. IN NO EVENT SHALL THE AUTHOR OR CONTRIBUTORS BE LIABLE FOR
- * ANY DIRECT, INDIRECT, INCIDENTAL, SPECIAL, EXEMPLARY, OR CONSEQUENTIAL
- * DAMAGES (INCLUDING, BUT NOT LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS
- * OR SERVICES; LOSS OF USE, DATA, OR PROFITS; OR BUSINESS INTERRUPTION)
- * HOWEVER CAUSED AND ON ANY THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT
- * LIABILITY, OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY
- * OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF
- * SUCH DAMAGE.
  */
 
 #include <linux/kernel.h>
-- 
2.43.0

Re: [PATCH v2] ALSA: usb-audio: Add SPDX id to midi.c

[Richard Fontana]

On Tue, Feb 17, 2026 at 6:42 PM Tim Bird <tim.bird@sony.com> wrote:
>
> Add an SPDX-License-Identifier line to sound/usb/midi.c
> Use 'BSD-Source-Code' as part of the OR for the
> license id.
>

> - * Redistribution and use in source and binary forms, with or without
> - * modification, are permitted provided that the following conditions
> - * are met:
> - * 1. Redistributions of source code must retain the above copyright
> - *    notice, this list of conditions, and the following disclaimer,
> - *    without modification.
> - * 2. The name of the author may not be used to endorse or promote products
> - *    derived from this software without specific prior written permission.
> - *
> - * Alternatively, this software may be distributed and/or modified under the
> - * terms of the GNU General Public License as published by the Free Software
> - * Foundation; either version 2 of the License, or (at your option) any later
> - * version.
> - *
> - * THIS SOFTWARE IS PROVIDED BY THE AUTHOR AND CONTRIBUTORS ``AS IS'' AND
> - * ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE
> - * IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR PURPOSE
> - * ARE DISCLAIMED. IN NO EVENT SHALL THE AUTHOR OR CONTRIBUTORS BE LIABLE FOR
> - * ANY DIRECT, INDIRECT, INCIDENTAL, SPECIAL, EXEMPLARY, OR CONSEQUENTIAL
> - * DAMAGES (INCLUDING, BUT NOT LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS
> - * OR SERVICES; LOSS OF USE, DATA, OR PROFITS; OR BUSINESS INTERRUPTION)
> - * HOWEVER CAUSED AND ON ANY THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT
> - * LIABILITY, OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY
> - * OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF
> - * SUCH DAMAGE.

This isn't `BSD-Source-Code`.

Richard

RE: [PATCH v2] ALSA: usb-audio: Add SPDX id to midi.c

[Bird, Tim]

> -----Original Message-----
> From: Richard Fontana <rfontana@redhat.com>
> On Tue, Feb 17, 2026 at 6:42 PM Tim Bird <tim.bird@sony.com> wrote:
> >
> > Add an SPDX-License-Identifier line to sound/usb/midi.c
> > Use 'BSD-Source-Code' as part of the OR for the
> > license id.
> >
> 
> > - * Redistribution and use in source and binary forms, with or without
> > - * modification, are permitted provided that the following conditions
> > - * are met:
> > - * 1. Redistributions of source code must retain the above copyright
> > - *    notice, this list of conditions, and the following disclaimer,
> > - *    without modification.
> > - * 2. The name of the author may not be used to endorse or promote products
> > - *    derived from this software without specific prior written permission.
> > - *
> > - * Alternatively, this software may be distributed and/or modified under the
> > - * terms of the GNU General Public License as published by the Free Software
> > - * Foundation; either version 2 of the License, or (at your option) any later
> > - * version.
> > - *
> > - * THIS SOFTWARE IS PROVIDED BY THE AUTHOR AND CONTRIBUTORS ``AS IS'' AND
> > - * ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE
> > - * IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR PURPOSE
> > - * ARE DISCLAIMED. IN NO EVENT SHALL THE AUTHOR OR CONTRIBUTORS BE LIABLE FOR
> > - * ANY DIRECT, INDIRECT, INCIDENTAL, SPECIAL, EXEMPLARY, OR CONSEQUENTIAL
> > - * DAMAGES (INCLUDING, BUT NOT LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS
> > - * OR SERVICES; LOSS OF USE, DATA, OR PROFITS; OR BUSINESS INTERRUPTION)
> > - * HOWEVER CAUSED AND ON ANY THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT
> > - * LIABILITY, OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY
> > - * OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF
> > - * SUCH DAMAGE.
> 
> This isn't `BSD-Source-Code`.

What difference do you think is important?

I know there are some textual differences, but I believe that this text is semantically equivalent
to BSD-Source-Code. It matches exactly with the license file that I added to the kernel in this
same patch.  If you're referring to the 4th sentence, that's not part of the BSD-Source-Code
license, and is reflected in the other side of the 'OR' clause in the SDPX ID I assigned to this file.
'GPL-2.0-or-later OR BSD-Source-Code'

 -- Tim