* Re: [PATCH v2] powerpc: Add missing SPDX license identifiers to DTS files
[not found] <633873803244c2122381cb11228a6a9a7385abd4.1642402958.git.christophe.leroy@csgroup.eu>
@ 2022-01-17 8:17 ` Greg Kroah-Hartman
0 siblings, 0 replies; only message in thread
From: Greg Kroah-Hartman @ 2022-01-17 8:17 UTC (permalink / raw)
To: Christophe Leroy
Cc: Benjamin Herrenschmidt, Paul Mackerras, Michael Ellerman,
linux-kernel@vger.kernel.org, linuxppc-dev@lists.ozlabs.org,
Thomas Gleixner, linux-spdx@vger.kernel.org
On Mon, Jan 17, 2022 at 07:03:45AM +0000, Christophe Leroy wrote:
> Several DTS files are missing SPDX license identifiers.
Normally DTS files are not just GPLv2, are you sure this is intended?
>
> For files in fsl/ subdirectory, GPL v2 or later is used based
> on the comments in the files.
You do not seem to have gotten the license correct for these, the text
in the file comments disagrees with GPLv2+ only.
Please be VERY careful when adding license tags to files like this, if
this patch was accepted it would get very confusing as they are
contradictions in the file itself suddenly.
Also, when adding SPDX lines, remove the boiler-plate license text at
the same time so that we can verify that the SPDX line is correct. If
you had done that here, it would be obvious that the patch is incorrect.
As-is, this patch is not acceptable, sorry.
greg k-h
^ permalink raw reply [flat|nested] only message in thread