Re: [PATCH v3] powerpc: Add missing SPDX license identifiers

Christophe Leroy
2022-01-21T15:34:30Z

Le 21/01/2022 à 16:19, Greg Kroah-Hartman a écrit :
> On Fri, Jan 21, 2022 at 03:13:50PM +0000, Christophe Leroy wrote:
>>
>>
>> Le 21/01/2022 à 15:35, Greg Kroah-Hartman a écrit :

...

>>>> @@ -20,16 +16,6 @@
>>>> * respects; for example, they cover modification of the file, and
>>>> * distribution when not linked into another program.)
>>>> *
>>>> - * This file is distributed in the hope that it will be useful, but
>>>> - * WITHOUT ANY WARRANTY; without even the implied warranty of
>>>> - * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU
>>>> - * General Public License for more details.
>>>> - *
>>>> - * You should have received a copy of the GNU General Public License
>>>> - * along with this program; see the file COPYING. If not, write to
>>>> - * the Free Software Foundation, 51 Franklin Street, Fifth Floor,
>>>> - * Boston, MA 02110-1301, USA.
>>>> - *
>>>> * As a special exception, if you link this library with files
>>>> * compiled with GCC to produce an executable, this does not cause
>>>> * the resulting executable to be covered by the GNU General Public License.
>>>
>>> Look at that "special exception", why are you ignoring it here? You
>>> can't do that :(
>>
>> I'm not ignoring it, that's the reason why I left it.
>
> You ignore that part of the license in the SPDX line, why?
>
>> Isn't it the correct way to do ? How should it be done ?
>
> You need to properly describe this in the SPDX line. You did not do so
> here, which means that any tool just looking at the SPDX line would get
> this license wrong.

How do you describe such an exception on the SPDX line then ?

You add " WITH GCC-exception-2.0" to the SPDX line ? Am I understanding
correctly ?

Thanks
Christophe