Re: [PATCH] crypto: md4: Fix checkpatch issues

Re: [PATCH] crypto: md4: Fix checkpatch issues

[Bagas Sanjaya]

[-- Attachment #1: Type: text/plain, Size: 1104 bytes --]

On Tue, Jun 06, 2023 at 01:26:10PM +0200, Franziska Naepelt wrote:
> The following checkpatch issues have been fixed:
> - WARNING: Missing or malformed SPDX-License-Identifier tag in line 1
> - ERROR: space required after that ',' (ctx:VxV)
> - ERROR: space prohibited after that open square bracket '['
> - WARNING: space prohibited between function name and open parenthesis '('
> - ERROR: code indent should use tabs where possible

Again, please split up into one patch per fixes, as a patch series.

> 
> not fixed:
> - ERROR: space required after that ',' (ctx:VxV)
> in lines: 64, 65, 66 have not ben fixed due to readability

Can you clearly explain why do you skip #define ROUNDx macros?

> -/* 
> +// SPDX-License-Identifier: GPL-2.0-or-later
> +/*
>   * Cryptographic API.
>   *
>   * MD4 Message Digest Algorithm (RFC1320).

What about removing the license boilerplate text below (and thus convert
to SPDX)? Personally, I prefer having a SPDX conversion series for crypto/
directory instead.

Thanks.

-- 
An old man doll... just what I always wanted! - Clara

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]

Re: [PATCH] crypto: md4: Fix checkpatch issues

[Ard Biesheuvel]

On Tue, 6 Jun 2023 at 14:15, Bagas Sanjaya <bagasdotme@gmail.com> wrote:
>
> On Tue, Jun 06, 2023 at 01:26:10PM +0200, Franziska Naepelt wrote:
> > The following checkpatch issues have been fixed:
> > - WARNING: Missing or malformed SPDX-License-Identifier tag in line 1
> > - ERROR: space required after that ',' (ctx:VxV)
> > - ERROR: space prohibited after that open square bracket '['
> > - WARNING: space prohibited between function name and open parenthesis '('
> > - ERROR: code indent should use tabs where possible
>
> Again, please split up into one patch per fixes, as a patch series.
>

Apart from the SPDX conversion, I think it is fine to fix multiple
different whitespace issues in the same file with one patch. Splitting
that up is just busywork.


> >
> > not fixed:
> > - ERROR: space required after that ',' (ctx:VxV)
> > in lines: 64, 65, 66 have not ben fixed due to readability
>
> Can you clearly explain why do you skip #define ROUNDx macros?
>
> > -/*
> > +// SPDX-License-Identifier: GPL-2.0-or-later
> > +/*
> >   * Cryptographic API.
> >   *
> >   * MD4 Message Digest Algorithm (RFC1320).
>
> What about removing the license boilerplate text below (and thus convert
> to SPDX)? Personally, I prefer having a SPDX conversion series for crypto/
> directory instead.
>
> Thanks.
>
> --
> An old man doll... just what I always wanted! - Clara

Re: [PATCH] crypto: md4: Fix checkpatch issues

[Bagas Sanjaya]

On 6/6/23 19:18, Ard Biesheuvel wrote:
> On Tue, 6 Jun 2023 at 14:15, Bagas Sanjaya <bagasdotme@gmail.com> wrote:
>>
>> On Tue, Jun 06, 2023 at 01:26:10PM +0200, Franziska Naepelt wrote:
>>> The following checkpatch issues have been fixed:
>>> - WARNING: Missing or malformed SPDX-License-Identifier tag in line 1
>>> - ERROR: space required after that ',' (ctx:VxV)
>>> - ERROR: space prohibited after that open square bracket '['
>>> - WARNING: space prohibited between function name and open parenthesis '('
>>> - ERROR: code indent should use tabs where possible
>>
>> Again, please split up into one patch per fixes, as a patch series.
>>
> 
> Apart from the SPDX conversion, I think it is fine to fix multiple
> different whitespace issues in the same file with one patch. Splitting
> that up is just busywork.
> 

Do you mean SPDX conversion in one patch and the rest in another? I think
so and confused...

-- 
An old man doll... just what I always wanted! - Clara