From: Kyoungil Kim <ki0351.kim@samsung.com>
To: spi-devel-general@lists.sourceforge.net,
linux-samsung-soc@vger.kernel.org
Cc: 'Sylwester Nawrocki' <s.nawrocki@samsung.com>
Subject: RE: [PATCH] spi: Add the use of DMA config operation
Date: Wed, 08 Feb 2012 19:34:28 +0900 [thread overview]
Message-ID: <000101cce64d$3c778d80$b566a880$%kim@samsung.com> (raw)
In-Reply-To: <4F3248ED.8030408@samsung.com>
Hi,
Sylwester Nawrocki wrote:
> Hi,
>
> On 02/08/2012 07:52 AM, Kyoungil Kim wrote:
> > Config operation is separated from request operation in DMA common operation.
> > Because spi driver can change the DMA config for every message.
> > So this patch is using the separated DMA config operation.
> >
> > Signed-off-by: Boojin Kim <boojin.kim@samsung.com>
> > Signed-off-by: Kyoungil Kim <ki0351.kim@samsung.com>
> > ---
> > drivers/spi/spi-s3c64xx.c | 35 +++++++++++++++++++++--------------
> > 1 files changed, 21 insertions(+), 14 deletions(-)
>
> I'm getting following compilation errors with this patch:
>
> CC drivers/spi/spi-s3c64xx.o
> drivers/spi/spi-s3c64xx.c: In function 'prepare_dma':
> drivers/spi/spi-s3c64xx.c:268: error: storage size of 'info' isn't known
> drivers/spi/spi-s3c64xx.c:269: error: storage size of 'config' isn't known
> drivers/spi/spi-s3c64xx.c:278: error: 'struct samsung_dma_ops' has no member
> named 'config'
> drivers/spi/spi-s3c64xx.c:286: error: 'struct samsung_dma_ops' has no member
> named 'config'
> drivers/spi/spi-s3c64xx.c:269: warning: unused variable 'config'
> drivers/spi/spi-s3c64xx.c:268: warning: unused variable 'info'
> drivers/spi/spi-s3c64xx.c: In function 'acquire_dma':
> drivers/spi/spi-s3c64xx.c:302: error: storage size of 'req' isn't known
> drivers/spi/spi-s3c64xx.c:302: warning: unused variable 'req'
>
> Which tree has it been created off of ?
>
> It seems there are some patches not yet in mainline that it depends on.
I'm sorry, I thought that the dependant patch was already in mainline.
I'll re-send it with dependant patch.
Thank you.
Best Regards.
prev parent reply other threads:[~2012-02-08 10:34 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-02-08 6:52 [PATCH] spi: Add the use of DMA config operation Kyoungil Kim
2012-02-08 10:05 ` Sylwester Nawrocki
2012-02-08 10:34 ` Kyoungil Kim [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='000101cce64d$3c778d80$b566a880$%kim@samsung.com' \
--to=ki0351.kim@samsung.com \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=s.nawrocki@samsung.com \
--cc=spi-devel-general@lists.sourceforge.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).