From: Jingoo Han <jg1.han-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org>
To: 'Mark Brown' <broonie-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
Cc: linux-spi-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
"'Marek Vašut'" <marex-ynQEQJNshbs@public.gmane.org>,
"'Jingoo Han'" <jg1.han-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org>
Subject: [PATCH 4/9] spi: spi-mxs: Fix checkpatch issue
Date: Tue, 02 Sep 2014 11:50:48 +0900 [thread overview]
Message-ID: <002401cfc658$b32398f0$196acad0$%han@samsung.com> (raw)
In-Reply-To: <002101cfc658$4f627cf0$ee2776d0$%han-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org>
Fix the following checkpatch warnings.
WARNING: Missing a blank line after declarations
WARNING: Prefer kcalloc over kzalloc with multiply
Signed-off-by: Jingoo Han <jg1.han-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org>
---
drivers/spi/spi-mxs.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/drivers/spi/spi-mxs.c b/drivers/spi/spi-mxs.c
index 2884f0c2f5f0..c3f8d3a22472 100644
--- a/drivers/spi/spi-mxs.c
+++ b/drivers/spi/spi-mxs.c
@@ -154,12 +154,14 @@ static int mxs_ssp_wait(struct mxs_spi *spi, int offset, int mask, bool set)
static void mxs_ssp_dma_irq_callback(void *param)
{
struct mxs_spi *spi = param;
+
complete(&spi->c);
}
static irqreturn_t mxs_ssp_irq_handler(int irq, void *dev_id)
{
struct mxs_ssp *ssp = dev_id;
+
dev_err(ssp->dev, "%s[%i] CTRL1=%08x STATUS=%08x\n",
__func__, __LINE__,
readl(ssp->base + HW_SSP_CTRL1(ssp)),
@@ -189,7 +191,7 @@ static int mxs_spi_txrx_dma(struct mxs_spi *spi,
if (!len)
return -EINVAL;
- dma_xfer = kzalloc(sizeof(*dma_xfer) * sgs, GFP_KERNEL);
+ dma_xfer = kcalloc(sgs, sizeof(*dma_xfer), GFP_KERNEL);
if (!dma_xfer)
return -ENOMEM;
--
2.0.0
--
To unsubscribe from this list: send the line "unsubscribe linux-spi" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2014-09-02 2:50 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-09-02 2:48 [PATCH 1/9] spi: davinci: Fix checkpatch issue Jingoo Han
[not found] ` <002101cfc658$4f627cf0$ee2776d0$%han-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org>
2014-09-02 2:49 ` [PATCH 2/9] spi: dw: " Jingoo Han
2014-09-02 2:50 ` [PATCH 3/9] spi: ep93xx: " Jingoo Han
[not found] ` <002301cfc658$9eb72c60$dc258520$%han-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org>
2014-09-02 5:02 ` Mika Westerberg
2014-09-02 10:47 ` Mark Brown
2014-09-02 2:50 ` Jingoo Han [this message]
[not found] ` <002401cfc658$b32398f0$196acad0$%han-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org>
2014-09-02 12:15 ` [PATCH 4/9] spi: spi-mxs: " Marek Vasut
2014-09-02 16:32 ` Mark Brown
2014-09-02 2:51 ` [PATCH 5/9] spi: orion: " Jingoo Han
2014-09-02 2:52 ` [PATCH 6/9] spi: tegra114: " Jingoo Han
2014-09-02 2:53 ` [PATCH 7/9] spi: tegra20-sflash: " Jingoo Han
2014-09-02 2:53 ` [PATCH 8/9] spi: txx9: " Jingoo Han
2014-09-02 2:54 ` [PATCH 9/9] spi: xtensa-xtfpga: " Jingoo Han
[not found] ` <002901cfc659$3b9a9850$b2cfc8f0$%han-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org>
2014-09-02 9:46 ` Max Filippov
2014-09-02 10:47 ` Mark Brown
2014-09-03 18:30 ` [PATCH 1/9] spi: davinci: " Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='002401cfc658$b32398f0$196acad0$%han@samsung.com' \
--to=jg1.han-sze3o3uu22jbdgjk7y7tuq@public.gmane.org \
--cc=broonie-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org \
--cc=linux-spi-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=marex-ynQEQJNshbs@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).