linux-spi.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Jingoo Han <jg1.han-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org>
To: 'Christian Engelmayer' <cengelma-RbZlAiThDcE@public.gmane.org>,
	'Mark Brown' <broonie-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
Cc: 'H Hartley Sweeten'
	<hsweeten-3FF4nKcrg1dE2c76skzGb0EOCMrvLtNR@public.gmane.org>,
	'Stephen Warren'
	<swarren-3lzwWm7+Weoh9ZMKESR00Q@public.gmane.org>,
	'Michal Nazarewicz'
	<mina86-deATy8a+UHjQT0dZR+AlfA@public.gmane.org>,
	linux-spi-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	'Jingoo Han' <jg1.han-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org>
Subject: Re: [PATCH] spi: omap-100k: Remove unused pointer in omap1_spi100k_txrx_pio()
Date: Mon, 10 Feb 2014 08:54:30 +0900	[thread overview]
Message-ID: <002e01cf25f2$45dbf4b0$d193de10$%han@samsung.com> (raw)
In-Reply-To: <20140208190223.45d1dcf8@spike>

On Sunday, February 09, 2014 3:02 AM, Christian Engelmayer wrote:
> 
> Remove unused devdata pointer 'spi100k' in function omap1_spi100k_txrx_pio().
> 
> Detected by Coverity: CID 1077869.
> 
> Signed-off-by: Christian Engelmayer <cengelma-RbZlAiThDcE@public.gmane.org>

Reviewed-by: Jingoo Han <jg1.han-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org>

Best regards,
Jingoo Han

> ---
> Applies against v3.14-rc1 as well as branch for-next in tree
> git.kernel.org/pub/scm/linux/kernel/git/broonie/spi.git
> ---
>  drivers/spi/spi-omap-100k.c | 2 --
>  1 file changed, 2 deletions(-)
> 
> diff --git a/drivers/spi/spi-omap-100k.c b/drivers/spi/spi-omap-100k.c
> index 0d32054..8eaf0cd 100644
> --- a/drivers/spi/spi-omap-100k.c
> +++ b/drivers/spi/spi-omap-100k.c
> @@ -204,12 +204,10 @@ static void omap1_spi100k_force_cs(struct omap1_spi100k *spi100k, int enable)
>  static unsigned
>  omap1_spi100k_txrx_pio(struct spi_device *spi, struct spi_transfer *xfer)
>  {
> -	struct omap1_spi100k    *spi100k;
>  	struct omap1_spi100k_cs *cs = spi->controller_state;
>  	unsigned int            count, c;
>  	int                     word_len;
> 
> -	spi100k = spi_master_get_devdata(spi->master);
>  	count = xfer->len;
>  	c = count;
>  	word_len = cs->word_len;
> --
> 1.8.3.2

--
To unsubscribe from this list: send the line "unsubscribe linux-spi" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

  reply	other threads:[~2014-02-09 23:54 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-02-08 18:02 [PATCH] spi: omap-100k: Remove unused pointer in omap1_spi100k_txrx_pio() Christian Engelmayer
2014-02-09 23:54 ` Jingoo Han [this message]
2014-02-10 10:09 ` Michal Nazarewicz
2014-02-10 12:17 ` Mark Brown

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='002e01cf25f2$45dbf4b0$d193de10$%han@samsung.com' \
    --to=jg1.han-sze3o3uu22jbdgjk7y7tuq@public.gmane.org \
    --cc=broonie-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org \
    --cc=cengelma-RbZlAiThDcE@public.gmane.org \
    --cc=hsweeten-3FF4nKcrg1dE2c76skzGb0EOCMrvLtNR@public.gmane.org \
    --cc=linux-spi-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=mina86-deATy8a+UHjQT0dZR+AlfA@public.gmane.org \
    --cc=swarren-3lzwWm7+Weoh9ZMKESR00Q@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).