[PATCH] spi: omap-100k: Remove unused pointer in omap1_spi100k_txrx_pio()

[PATCH] spi: omap-100k: Remove unused pointer in omap1_spi100k_txrx_pio()

[Christian Engelmayer]

[-- Attachment #1: Type: text/plain, Size: 1067 bytes --]

Remove unused devdata pointer 'spi100k' in function omap1_spi100k_txrx_pio().

Detected by Coverity: CID 1077869.

Signed-off-by: Christian Engelmayer <cengelma-RbZlAiThDcE@public.gmane.org>
---
Applies against v3.14-rc1 as well as branch for-next in tree
git.kernel.org/pub/scm/linux/kernel/git/broonie/spi.git
---
 drivers/spi/spi-omap-100k.c | 2 --
 1 file changed, 2 deletions(-)

diff --git a/drivers/spi/spi-omap-100k.c b/drivers/spi/spi-omap-100k.c
index 0d32054..8eaf0cd 100644
--- a/drivers/spi/spi-omap-100k.c
+++ b/drivers/spi/spi-omap-100k.c
@@ -204,12 +204,10 @@ static void omap1_spi100k_force_cs(struct omap1_spi100k *spi100k, int enable)
 static unsigned
 omap1_spi100k_txrx_pio(struct spi_device *spi, struct spi_transfer *xfer)
 {
-	struct omap1_spi100k    *spi100k;
 	struct omap1_spi100k_cs *cs = spi->controller_state;
 	unsigned int            count, c;
 	int                     word_len;
 
-	spi100k = spi_master_get_devdata(spi->master);
 	count = xfer->len;
 	c = count;
 	word_len = cs->word_len;
-- 
1.8.3.2

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 836 bytes --]

Re: [PATCH] spi: omap-100k: Remove unused pointer in omap1_spi100k_txrx_pio()

[Jingoo Han]

On Sunday, February 09, 2014 3:02 AM, Christian Engelmayer wrote:
> 
> Remove unused devdata pointer 'spi100k' in function omap1_spi100k_txrx_pio().
> 
> Detected by Coverity: CID 1077869.
> 
> Signed-off-by: Christian Engelmayer <cengelma-RbZlAiThDcE@public.gmane.org>

Reviewed-by: Jingoo Han <jg1.han-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org>

Best regards,
Jingoo Han

> ---
> Applies against v3.14-rc1 as well as branch for-next in tree
> git.kernel.org/pub/scm/linux/kernel/git/broonie/spi.git
> ---
>  drivers/spi/spi-omap-100k.c | 2 --
>  1 file changed, 2 deletions(-)
> 
> diff --git a/drivers/spi/spi-omap-100k.c b/drivers/spi/spi-omap-100k.c
> index 0d32054..8eaf0cd 100644
> --- a/drivers/spi/spi-omap-100k.c
> +++ b/drivers/spi/spi-omap-100k.c
> @@ -204,12 +204,10 @@ static void omap1_spi100k_force_cs(struct omap1_spi100k *spi100k, int enable)
>  static unsigned
>  omap1_spi100k_txrx_pio(struct spi_device *spi, struct spi_transfer *xfer)
>  {
> -	struct omap1_spi100k    *spi100k;
>  	struct omap1_spi100k_cs *cs = spi->controller_state;
>  	unsigned int            count, c;
>  	int                     word_len;
> 
> -	spi100k = spi_master_get_devdata(spi->master);
>  	count = xfer->len;
>  	c = count;
>  	word_len = cs->word_len;
> --
> 1.8.3.2

--
To unsubscribe from this list: send the line "unsubscribe linux-spi" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH] spi: omap-100k: Remove unused pointer in omap1_spi100k_txrx_pio()

[Michal Nazarewicz]

[-- Attachment #1: Type: text/plain, Size: 1626 bytes --]

On Sat, Feb 08 2014, Christian Engelmayer <cengelma-RbZlAiThDcE@public.gmane.org> wrote:
> Remove unused devdata pointer 'spi100k' in function omap1_spi100k_txrx_pio().
>
> Detected by Coverity: CID 1077869.
>
> Signed-off-by: Christian Engelmayer <cengelma-RbZlAiThDcE@public.gmane.org>

Acked-by: Michal Nazarewicz <mina86-deATy8a+UHjQT0dZR+AlfA@public.gmane.org>

> ---
> Applies against v3.14-rc1 as well as branch for-next in tree
> git.kernel.org/pub/scm/linux/kernel/git/broonie/spi.git
> ---
>  drivers/spi/spi-omap-100k.c | 2 --
>  1 file changed, 2 deletions(-)
>
> diff --git a/drivers/spi/spi-omap-100k.c b/drivers/spi/spi-omap-100k.c
> index 0d32054..8eaf0cd 100644
> --- a/drivers/spi/spi-omap-100k.c
> +++ b/drivers/spi/spi-omap-100k.c
> @@ -204,12 +204,10 @@ static void omap1_spi100k_force_cs(struct omap1_spi100k *spi100k, int enable)
>  static unsigned
>  omap1_spi100k_txrx_pio(struct spi_device *spi, struct spi_transfer *xfer)
>  {
> -	struct omap1_spi100k    *spi100k;
>  	struct omap1_spi100k_cs *cs = spi->controller_state;
>  	unsigned int            count, c;
>  	int                     word_len;
>  
> -	spi100k = spi_master_get_devdata(spi->master);
>  	count = xfer->len;
>  	c = count;
>  	word_len = cs->word_len;
> -- 
> 1.8.3.2

-- 
Best regards,                                         _     _
.o. | Liege of Serenely Enlightened Majesty of      o' \,=./ `o
..o | Computer Science,  Michał “mina86” Nazarewicz    (o o)
ooo +--<mpn-hpIqsD4AKlfQT0dZR+AlfA@public.gmane.org>--<xmpp:mina86-/eSpBmjxGS4dnm+yROfE0A@public.gmane.org>--ooO--(_)--Ooo--

[-- Attachment #2.1: Type: text/plain, Size: 0 bytes --]



[-- Attachment #2.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 835 bytes --]

Re: [PATCH] spi: omap-100k: Remove unused pointer in omap1_spi100k_txrx_pio()

[Mark Brown]

[-- Attachment #1: Type: text/plain, Size: 214 bytes --]

On Sat, Feb 08, 2014 at 07:02:23PM +0100, Christian Engelmayer wrote:
> Remove unused devdata pointer 'spi100k' in function omap1_spi100k_txrx_pio().
> 
> Detected by Coverity: CID 1077869.

Applied, thanks.

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]