RT5350 spi half duplex?

["Giuseppe Lippolis" <giu.lippolis-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>]

Hi,
I’m experimenting the spi interface on a RT5350 target.
Its spi driver set the interface as half duplex

        master->dev.of_node = pdev->dev.of_node;
        master->mode_bits = RT2880_SPI_MODE_BITS;
        master->bits_per_word_mask = SPI_BPW_MASK(8);
        master->min_speed_hz = clk_get_rate(clk) / 128;
        master->max_speed_hz = clk_get_rate(clk) / 2;
        master->flags = SPI_MASTER_HALF_DUPLEX;
        master->setup = rt2880_spi_setup;
        master->prepare_message = rt2880_spi_prepare_message;
        master->set_cs = rt2880_spi_set_cs;
        master->transfer_one = rt2880_spi_transfer_one,

but from the datasheet it seems that the device is full duplex capable.
Is there any reason to set the driver in this way?

By the way my debug was not easy because the 

      static int __spi_validate(struct spi_device *spi, struct spi_message
*message)
      
in spi.c doesn’t report any error message when an error condition is found.
Is there any reason to do in this way?
Can I send a patch with some error message?

Thanks, bye. 


--
To unsubscribe from this list: send the line "unsubscribe linux-spi" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html