linux-spi.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* RT5350 spi half duplex?
@ 2017-01-18 20:39 Giuseppe Lippolis
  2017-01-21  7:57 ` AW: " Giuseppe Lippolis
  0 siblings, 1 reply; 2+ messages in thread
From: Giuseppe Lippolis @ 2017-01-18 20:39 UTC (permalink / raw)
  To: linux-spi-u79uwXL29TY76Z2rM5mHXA

Hi,
I’m experimenting the spi interface on a RT5350 target.
Its spi driver set the interface as half duplex

        master->dev.of_node = pdev->dev.of_node;
        master->mode_bits = RT2880_SPI_MODE_BITS;
        master->bits_per_word_mask = SPI_BPW_MASK(8);
        master->min_speed_hz = clk_get_rate(clk) / 128;
        master->max_speed_hz = clk_get_rate(clk) / 2;
        master->flags = SPI_MASTER_HALF_DUPLEX;
        master->setup = rt2880_spi_setup;
        master->prepare_message = rt2880_spi_prepare_message;
        master->set_cs = rt2880_spi_set_cs;
        master->transfer_one = rt2880_spi_transfer_one,

but from the datasheet it seems that the device is full duplex capable.
Is there any reason to set the driver in this way?

By the way my debug was not easy because the 

      static int __spi_validate(struct spi_device *spi, struct spi_message
*message)
      
in spi.c doesn’t report any error message when an error condition is found.
Is there any reason to do in this way?
Can I send a patch with some error message?

Thanks, bye. 


--
To unsubscribe from this list: send the line "unsubscribe linux-spi" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2017-01-21  7:57 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2017-01-18 20:39 RT5350 spi half duplex? Giuseppe Lippolis
2017-01-21  7:57 ` AW: " Giuseppe Lippolis

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).