From: "Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>
To: Mark Brown <broonie@kernel.org>
Cc: kernel@pengutronix.de, Jonathan Corbet <corbet@lwn.net>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Jonathan Cameron <Jonathan.Cameron@huawei.com>,
James Clark <james.clark@arm.com>,
Bjorn Helgaas <bhelgaas@google.com>,
Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-spi@vger.kernel.org
Subject: [PATCH v2 32/33] spi: Drop compat layer from renaming "master" to "controller"
Date: Mon, 22 Jan 2024 19:07:27 +0100 [thread overview]
Message-ID: <0107400bb6616ac78c01215320a6bbe6a0d10e7c.1705944943.git.u.kleine-koenig@pengutronix.de> (raw)
In-Reply-To: <cover.1705944943.git.u.kleine-koenig@pengutronix.de>
Now that all in-tree users followed the rename, the compat stuff can go
away. This completes the renaming started with commit 8caab75fd2c2
("spi: Generalize SPI "master" to "controller"")
Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
---
.../driver-api/driver-model/devres.rst | 2 +-
drivers/spi/spi.c | 2 +-
include/linux/spi/spi.h | 20 +------------------
3 files changed, 3 insertions(+), 21 deletions(-)
diff --git a/Documentation/driver-api/driver-model/devres.rst b/Documentation/driver-api/driver-model/devres.rst
index c5f99d834ec5..49c6fd82cd5d 100644
--- a/Documentation/driver-api/driver-model/devres.rst
+++ b/Documentation/driver-api/driver-model/devres.rst
@@ -462,7 +462,7 @@ SLAVE DMA ENGINE
SPI
devm_spi_alloc_master()
devm_spi_alloc_slave()
- devm_spi_register_master()
+ devm_spi_register_controller()
WATCHDOG
devm_watchdog_register_device()
diff --git a/drivers/spi/spi.c b/drivers/spi/spi.c
index 7477a11e12be..2d7393045384 100644
--- a/drivers/spi/spi.c
+++ b/drivers/spi/spi.c
@@ -584,7 +584,7 @@ struct spi_device *spi_alloc_device(struct spi_controller *ctlr)
return NULL;
}
- spi->master = spi->controller = ctlr;
+ spi->controller = ctlr;
spi->dev.parent = &ctlr->dev;
spi->dev.bus = &spi_bus_type;
spi->dev.release = spidev_release;
diff --git a/include/linux/spi/spi.h b/include/linux/spi/spi.h
index 471fe2ff9066..6a4f8cbba5ef 100644
--- a/include/linux/spi/spi.h
+++ b/include/linux/spi/spi.h
@@ -131,7 +131,6 @@ extern void spi_transfer_cs_change_delay_exec(struct spi_message *msg,
* struct spi_device - Controller side proxy for an SPI slave device
* @dev: Driver model representation of the device.
* @controller: SPI controller used with the device.
- * @master: Copy of controller, for backwards compatibility.
* @max_speed_hz: Maximum clock rate to be used with this chip
* (on this board); may be changed by the device's driver.
* The spi_transfer.speed_hz can override this for each transfer.
@@ -185,7 +184,6 @@ extern void spi_transfer_cs_change_delay_exec(struct spi_message *msg,
struct spi_device {
struct device dev;
struct spi_controller *controller;
- struct spi_controller *master; /* Compatibility layer */
u32 max_speed_hz;
u8 chip_select[SPI_CS_CNT_MAX];
u8 bits_per_word;
@@ -1298,7 +1296,7 @@ spi_max_transfer_size(struct spi_device *spi)
*/
static inline bool spi_is_bpw_supported(struct spi_device *spi, u32 bpw)
{
- u32 bpw_mask = spi->master->bits_per_word_mask;
+ u32 bpw_mask = spi->controller->bits_per_word_mask;
if (bpw == 8 || (bpw <= 32 && bpw_mask & SPI_BPW_MASK(bpw)))
return true;
@@ -1670,20 +1668,4 @@ spi_transfer_is_last(struct spi_controller *ctlr, struct spi_transfer *xfer)
return list_is_last(&xfer->transfer_list, &ctlr->cur_msg->transfers);
}
-/* Compatibility layer */
-#define spi_master spi_controller
-
-#define spi_master_get_devdata(_ctlr) spi_controller_get_devdata(_ctlr)
-#define spi_master_set_devdata(_ctlr, _data) \
- spi_controller_set_devdata(_ctlr, _data)
-#define spi_master_get(_ctlr) spi_controller_get(_ctlr)
-#define spi_master_put(_ctlr) spi_controller_put(_ctlr)
-#define spi_master_suspend(_ctlr) spi_controller_suspend(_ctlr)
-#define spi_master_resume(_ctlr) spi_controller_resume(_ctlr)
-
-#define spi_register_master(_ctlr) spi_register_controller(_ctlr)
-#define devm_spi_register_master(_dev, _ctlr) \
- devm_spi_register_controller(_dev, _ctlr)
-#define spi_unregister_master(_ctlr) spi_unregister_controller(_ctlr)
-
#endif /* __LINUX_SPI_H */
--
2.43.0
next prev parent reply other threads:[~2024-01-22 18:08 UTC|newest]
Thread overview: 55+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-01-22 18:06 [PATCH v2 00/33] spi: get rid of some legacy macros Uwe Kleine-König
2024-01-22 18:06 ` [PATCH v2 01/33] fpga: ice40-spi: Follow renaming of SPI "master" to "controller" Uwe Kleine-König
2024-01-22 18:06 ` [PATCH v2 02/33] ieee802154: ca8210: " Uwe Kleine-König
2024-01-22 18:16 ` Miquel Raynal
2024-01-22 18:06 ` [PATCH v2 03/33] iio: adc: ad_sigma_delta: " Uwe Kleine-König
2024-01-22 18:06 ` [PATCH v2 04/33] Input: pxspad - follow " Uwe Kleine-König
2024-01-22 18:07 ` [PATCH v2 05/33] Input: synaptics-rmi4 " Uwe Kleine-König
2024-01-22 18:07 ` [PATCH v2 06/33] media: mgb4: Follow " Uwe Kleine-König
2024-01-22 18:07 ` [PATCH v2 07/33] media: netup_unidvb: " Uwe Kleine-König
2024-02-07 4:43 ` Mauro Carvalho Chehab
2024-01-22 18:07 ` [PATCH v2 08/33] media: usb/msi2500: " Uwe Kleine-König
2024-01-22 18:07 ` [PATCH v2 09/33] media: v4l2-subdev: " Uwe Kleine-König
2024-01-22 18:07 ` [PATCH v2 10/33] misc: gehc-achc: " Uwe Kleine-König
2024-01-24 17:31 ` Greg Kroah-Hartman
2024-01-22 18:07 ` [PATCH v2 11/33] mmc: mmc_spi: " Uwe Kleine-König
2024-01-23 13:09 ` Ulf Hansson
2024-01-23 13:16 ` Mark Brown
2024-01-22 18:07 ` [PATCH v2 12/33] mtd: dataflash: " Uwe Kleine-König
2024-01-22 18:13 ` Miquel Raynal
2024-01-22 18:07 ` [PATCH v2 13/33] mtd: rawnand: fsl_elbc: Let .probe retry if local bus is missing Uwe Kleine-König
2024-01-22 18:19 ` Miquel Raynal
2024-01-22 21:29 ` Uwe Kleine-König
2024-01-22 18:07 ` [PATCH v2 14/33] net: ks8851: Follow renaming of SPI "master" to "controller" Uwe Kleine-König
2024-01-22 18:07 ` [PATCH v2 15/33] net: vertexcom: mse102x: " Uwe Kleine-König
2024-01-22 18:07 ` [PATCH v2 16/33] platform/chrome: cros_ec_spi: " Uwe Kleine-König
2024-01-22 18:07 ` [PATCH v2 17/33] spi: bitbang: " Uwe Kleine-König
2024-01-30 10:46 ` kernel test robot
2024-02-02 13:08 ` Uwe Kleine-König
2024-01-22 18:07 ` [PATCH v2 18/33] spi: cadence-quadspi: Don't emit error message on allocation error Uwe Kleine-König
2024-01-22 18:07 ` [PATCH v2 19/33] spi: cadence-quadspi: Follow renaming of SPI "master" to "controller" Uwe Kleine-König
2024-01-22 18:07 ` [PATCH v2 20/33] spi: cavium: " Uwe Kleine-König
2024-01-22 18:07 ` [PATCH v2 21/33] spi: geni-qcom: " Uwe Kleine-König
2024-01-22 18:07 ` [PATCH v2 22/33] spi: loopback-test: " Uwe Kleine-König
2024-01-22 18:07 ` [PATCH v2 23/33] spi: slave-mt27xx: " Uwe Kleine-König
2024-01-22 18:07 ` [PATCH v2 24/33] spi: spidev: " Uwe Kleine-König
2024-01-22 18:07 ` [PATCH v2 25/33] staging: fbtft: " Uwe Kleine-König
2024-01-24 17:31 ` Greg Kroah-Hartman
2024-01-22 18:07 ` [PATCH v2 26/33] staging: greybus: spi: " Uwe Kleine-König
2024-01-24 17:31 ` Greg Kroah-Hartman
2024-01-22 18:07 ` [PATCH v2 27/33] tpm_tis_spi: " Uwe Kleine-König
2024-01-22 18:07 ` [PATCH v2 28/33] usb: gadget: max3420_udc: " Uwe Kleine-König
2024-01-24 17:31 ` Greg Kroah-Hartman
2024-01-22 18:07 ` [PATCH v2 29/33] video: fbdev: mmp: " Uwe Kleine-König
2024-01-22 18:07 ` [PATCH v2 30/33] wifi: libertas: " Uwe Kleine-König
2024-01-22 18:07 ` [PATCH v2 31/33] spi: fsl-lib: " Uwe Kleine-König
2024-01-22 18:07 ` Uwe Kleine-König [this message]
2024-01-22 18:07 ` [PATCH v2 33/33] Documentation: spi: Update documentation for renaming " Uwe Kleine-König
2024-01-22 18:18 ` [PATCH v2 00/33] spi: get rid of some legacy macros Mark Brown
2024-01-22 19:23 ` Jonathan Cameron
2024-01-24 20:02 ` Jonathan Cameron
2024-01-24 17:13 ` Greg Kroah-Hartman
2024-01-24 17:22 ` Mark Brown
2024-01-24 17:30 ` Greg Kroah-Hartman
2024-02-01 21:47 ` Jarkko Sakkinen
2024-02-12 15:33 ` (subset) " Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0107400bb6616ac78c01215320a6bbe6a0d10e7c.1705944943.git.u.kleine-koenig@pengutronix.de \
--to=u.kleine-koenig@pengutronix.de \
--cc=Jonathan.Cameron@huawei.com \
--cc=andriy.shevchenko@linux.intel.com \
--cc=bhelgaas@google.com \
--cc=broonie@kernel.org \
--cc=corbet@lwn.net \
--cc=gregkh@linuxfoundation.org \
--cc=james.clark@arm.com \
--cc=kernel@pengutronix.de \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-spi@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).