From: Md Sadre Alam <quic_mdalam@quicinc.com>
To: Konrad Dybcio <konrad.dybcio@linaro.org>, <agross@kernel.org>,
<andersson@kernel.org>, <robh+dt@kernel.org>,
<conor+dt@kernel.org>, <krzysztof.kozlowski+dt@linaro.org>,
<miquel.raynal@bootlin.com>, <richard@nod.at>, <vigneshr@ti.com>,
<broonie@kernel.org>, <linux-arm-msm@vger.kernel.org>,
<devicetree@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
<linux-mtd@lists.infradead.org>, <linux-spi@vger.kernel.org>,
<quic_srichara@quicinc.com>, <qpic_varada@quicinc.com>
Subject: Re: [RFC PATCH 2/5] arm64: dts: qcom: ipq9574: Add ecc engine support
Date: Fri, 3 Nov 2023 16:56:17 +0530 [thread overview]
Message-ID: <0140b8b9-0043-4cf4-0704-7727774dba0f@quicinc.com> (raw)
In-Reply-To: <873c1b14-5b7c-4fb1-8f09-6344a4bf901b@linaro.org>
On 10/31/2023 8:53 PM, Konrad Dybcio wrote:
> On 31.10.2023 13:03, Md Sadre Alam wrote:
>> Signed-off-by: Md Sadre Alam <quic_mdalam@quicinc.com>
>> Signed-off-by: Sricharan R <quic_srichara@quicinc.com>
>> ---
> Hello,
>
> you're missing:
>
> - dt-bindings (make dtbs_check is unhappy)
> - a commit message
> - Co-developed-by for Sricharan
>
> status should read "okay" instead, but in this case it's unnecessary
> as you're defining the node and lack of the status property also means
> that device is enabled
>
> however
>
> this ECC engine seems to be a part of the NAND controller, so it's
> unlikely that the DT maintainers will agree for it to have a separate
> node
>
Will drop this patch as this was NAK-ed
QPIC controller has the ecc pipelined so will keep the ecc support
inlined in both raw nand and serial nand driver.
Regards
Alam.
next prev parent reply other threads:[~2023-11-03 11:26 UTC|newest]
Thread overview: 33+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-31 12:03 [RFC PATCH 0/5] Add QPIC SPI NAND driver support Md Sadre Alam
2023-10-31 12:03 ` [RFC PATCH 1/5] mtd: nand: ecc-qcom: Add support for ECC Engine Driver Md Sadre Alam
2023-10-31 15:28 ` Miquel Raynal
2023-11-03 12:06 ` Md Sadre Alam
2023-11-03 12:08 ` Krzysztof Kozlowski
2023-11-03 12:11 ` Krzysztof Kozlowski
2023-10-31 17:11 ` Krzysztof Kozlowski
2023-11-03 12:24 ` Md Sadre Alam
2023-11-03 12:33 ` Dmitry Baryshkov
2023-11-03 13:23 ` Md Sadre Alam
2023-11-03 13:46 ` Miquel Raynal
2023-11-20 6:30 ` Md Sadre Alam
2023-11-03 13:54 ` Dmitry Baryshkov
2023-10-31 12:03 ` [RFC PATCH 2/5] arm64: dts: qcom: ipq9574: Add ecc engine support Md Sadre Alam
2023-10-31 15:23 ` Konrad Dybcio
2023-11-03 11:26 ` Md Sadre Alam [this message]
2023-10-31 17:12 ` Krzysztof Kozlowski
2023-11-03 12:09 ` Md Sadre Alam
2023-10-31 12:03 ` [RFC PATCH 3/5] mtd: nand: qpic_common: Add support for qpic common API Md Sadre Alam
2023-10-31 15:54 ` Miquel Raynal
2023-10-31 12:03 ` [RFC PATCH 4/5] spi: qpic: Add support for qpic spi nand driver Md Sadre Alam
2023-10-31 14:23 ` Mark Brown
2023-11-03 11:20 ` Md Sadre Alam
2023-11-03 12:47 ` Mark Brown
2023-11-20 6:34 ` Md Sadre Alam
2023-10-31 17:13 ` Krzysztof Kozlowski
2023-11-03 12:13 ` Md Sadre Alam
2023-11-03 12:18 ` Krzysztof Kozlowski
2023-11-03 12:15 ` Md Sadre Alam
2023-10-31 12:03 ` [RFC PATCH 5/5] arm64: dts: qcom: ipq9574: Add support for SPI nand Md Sadre Alam
2023-10-31 15:27 ` Konrad Dybcio
2023-11-03 11:31 ` Md Sadre Alam
2023-10-31 17:17 ` Krzysztof Kozlowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0140b8b9-0043-4cf4-0704-7727774dba0f@quicinc.com \
--to=quic_mdalam@quicinc.com \
--cc=agross@kernel.org \
--cc=andersson@kernel.org \
--cc=broonie@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=konrad.dybcio@linaro.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mtd@lists.infradead.org \
--cc=linux-spi@vger.kernel.org \
--cc=miquel.raynal@bootlin.com \
--cc=qpic_varada@quicinc.com \
--cc=quic_srichara@quicinc.com \
--cc=richard@nod.at \
--cc=robh+dt@kernel.org \
--cc=vigneshr@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).