From: "Enrico Weigelt, metux IT consult" <lkml@metux.net>
To: Mark Brown <broonie@kernel.org>, Paul Cercueil <paul@crapouillou.net>
Cc: od@zcrc.me, linux-spi@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] spi: spi-gpio: Make probe function __init_or_module
Date: Mon, 24 Jun 2019 20:42:43 +0200 [thread overview]
Message-ID: <0323abd9-2c68-2d2e-0140-c34edf983f4f@metux.net> (raw)
In-Reply-To: <20190607155907.GH2456@sirena.org.uk>
On 07.06.19 17:59, Mark Brown wrote:
> On Fri, Jun 07, 2019 at 05:56:31PM +0200, Paul Cercueil wrote:
>> This allows the probe function to be dropped after the kernel finished
>> its initialization, in the case where the driver was not compiled as a
>> module.
>
> Hopefully not since we might probe later on if something registers a new
> device...
>
Common pitfall. Also fallen into this myself and wondered why
it oops'd :o.
--mtx
--
Enrico Weigelt, metux IT consult
Free software and Linux embedded engineering
info@metux.net -- +49-151-27565287
prev parent reply other threads:[~2019-06-24 18:42 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-06-07 15:56 [PATCH] spi: spi-gpio: Make probe function __init_or_module Paul Cercueil
2019-06-07 15:59 ` Mark Brown
2019-06-07 16:02 ` Paul Cercueil
2019-06-07 16:05 ` Mark Brown
2019-06-24 18:42 ` Enrico Weigelt, metux IT consult [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0323abd9-2c68-2d2e-0140-c34edf983f4f@metux.net \
--to=lkml@metux.net \
--cc=broonie@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-spi@vger.kernel.org \
--cc=od@zcrc.me \
--cc=paul@crapouillou.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).