From: Johannes Thumshirn <jth@kernel.org>
To: Mark Brown <broonie@kernel.org>
Cc: linux-kernel@vger.kernel.org, linux-spi@vger.kernel.org
Subject: Re: [PATCH] spi: add ch341a usb2spi driver
Date: Mon, 8 Jul 2024 13:55:18 +0200 [thread overview]
Message-ID: <0344c279-a678-4ac9-b4b1-6601f5a5a1aa@kernel.org> (raw)
In-Reply-To: <5890754d-50a7-4db6-a33e-bba64ca1389d@sirena.org.uk>
On 08/07/2024 13:32, Mark Brown wrote:
> On Mon, Jul 08, 2024 at 10:04:41AM +0200, Johannes Thumshirn wrote:
>> On 05/07/2024 19:41, Mark Brown wrote:
>
>>> No validation of speed?
>
>> TBH I haven't found a command that reads the current settings of the device.
>
> Why would reading things from the device be relevant to validating what
> we are writing?
Then I don't really understand your comment.
Why would I need to validate a constant? But indeed it doesn't make any
sense at all to pass in the speed parameter.
Will fix in v2.
prev parent reply other threads:[~2024-07-08 11:55 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-07-05 14:51 [PATCH] spi: add ch341a usb2spi driver Johannes Thumshirn
2024-07-05 17:41 ` Mark Brown
2024-07-08 8:04 ` Johannes Thumshirn
2024-07-08 11:32 ` Mark Brown
2024-07-08 11:55 ` Johannes Thumshirn [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0344c279-a678-4ac9-b4b1-6601f5a5a1aa@kernel.org \
--to=jth@kernel.org \
--cc=broonie@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-spi@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).