From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wr1-f49.google.com (mail-wr1-f49.google.com [209.85.221.49]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 743B513B791 for ; Mon, 3 Jun 2024 22:53:24 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.49 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1717455207; cv=none; b=JZ+e+D7eSbagyVoVXFhKofdBoyN6ppADReF2ZUIbigi2JTr2irTTxYs1J6r9GvFUf5gkU+cj+DcVGNBlSoJsjKWe+6tzWmksGdNaPApsv2VXC+f4wCdq6BXKaCiaWsc4iFwYOlDQnLMy/v33Pd2GNIb4ITKpBfQHi8jMr5Yy+Ck= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1717455207; c=relaxed/simple; bh=oBsznC+UevVh615u4wf6L5X3iY4TMbGxHYqIHduASSo=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=bfu4Kxv+p90iLSvIbJUCSdtebIHuMs/8KGTT3ipi3Tw++km4dFzQYh7x6cp7OnpMj5V3yBIhT/KZNbZDy1u55jMZluhqftQ/0Fu6Vl06VY25eNBTGIU8Vf/gt8o9PkbekogssEKuELbF9vy/8OLxcCgOfuJ4L9AqGhCYtyKVAfY= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=UNs1uKu5; arc=none smtp.client-ip=209.85.221.49 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="UNs1uKu5" Received: by mail-wr1-f49.google.com with SMTP id ffacd0b85a97d-35dce610207so2828390f8f.2 for ; Mon, 03 Jun 2024 15:53:24 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1717455203; x=1718060003; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=xHxPmcn8NBPRCew+UgSGoajPk8qIaDUfay5Y7XccfBs=; b=UNs1uKu55g77J1OncpXg5qq0J2hJrD4ecSRXgbrwLWBgxLZ3zeisMVM4Laod9cjsRI LzDPpRwhp1qH0ntPjaKqeppAYaKoJ67b4v/A6wzvGYcPbwx0b1WH76X+pQxc0fbYOCqD pdwHpjl352oXA7+YPDOixKQzwJOD1c80u+yoWH9zgo1FJhjRYRNhjdvFyAsAx4ltcoVY LNR7LZnL8MyT47hGr7LJh/AN/DBka+C7kyLsBP8+dqVCboJUsquLQTSYrmZZckVqc77E OdTWOWpyRN2onDVE8L9GtD8I+9oiWxjbkPaLToR3O+hVN5pCRbjdXACxHj0M/XT7uDZF A1NQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1717455203; x=1718060003; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=xHxPmcn8NBPRCew+UgSGoajPk8qIaDUfay5Y7XccfBs=; b=sq3QJ6GpCogMp7GyJzrQsU6uL+jfLrY5WTF4NZ1llawizdeHVXSJGrYEYywc1YSZpo eGSwrLhpJHTagD+X6sjfnGNkJjK4GclgXxr60MozKxQfFo1Z1zieIlyUWzHDg4VoroSj JCpK9PjS4auE8cGQjs3Zc4ddZzL9yYYg7jKlFeY3zvzKSXtyiB9JEdrO9W37i71D34yG RS0HEp/j5Q7JLN45cxl5fMCKZdD4AUcqGOmmReZpqGUD8qaWw2jm7nJK26oRxiNPSohZ xOgUKiZpgon+hkAu6p9p5UvXQUMEsiQXhpfRhiO1emGqNT4XWxExzArT8WvaRaKRYBH/ +ifw== X-Forwarded-Encrypted: i=1; AJvYcCXArGGApriu/lHIgRObeZF1PcTDGh5r/qOFB/qJZiiaq+Qb8E34aMVWB33mB6TjUMgd8PKtItZXO6nI8IIFpP20fyysA3G1s9GP X-Gm-Message-State: AOJu0YzOsr5lGOF7CPylDZsJhDRnYlr+5qXz+Q/Gm+VyrOwuHFL/S7zy WxQLn0HnbxHizvPNAUH7/z4ENZNmNNc5kL94/CjaL+b2mrvpN/aqdYYY0pH+7a0= X-Google-Smtp-Source: AGHT+IEURfJLad+7UzsuYE9O4FrsNz6zu5sZ7BCnFy+vex0kNyGPgn3BnDdjLi2iBPQGPBiHjPu9Vg== X-Received: by 2002:a05:600c:4f82:b0:421:222e:96db with SMTP id 5b1f17b1804b1-4212e0bfefcmr112147885e9.33.1717455202781; Mon, 03 Jun 2024 15:53:22 -0700 (PDT) Received: from [192.168.0.3] ([176.61.106.227]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-42133e66ce0sm111773405e9.23.2024.06.03.15.53.21 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 03 Jun 2024 15:53:22 -0700 (PDT) Message-ID: <036ed2c7-02da-4461-940f-591fa68c36fe@linaro.org> Date: Mon, 3 Jun 2024 23:53:20 +0100 Precedence: bulk X-Mailing-List: linux-spi@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v1 1/8] spi: Introduce internal spi_xfer_is_dma_mapped() helper To: Andy Shevchenko , Mark Brown , Yang Yingliang , Christophe JAILLET , Thangaraj Samynathan , linux-spi@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-arm-msm@vger.kernel.org Cc: Serge Semin , Daniel Mack , Haojian Zhuang , Robert Jarzmik , =?UTF-8?Q?N=C3=ADcolas_F_=2E_R_=2E_A_=2E_Prado?= , Neil Armstrong References: <20240531194723.1761567-1-andriy.shevchenko@linux.intel.com> <20240531194723.1761567-2-andriy.shevchenko@linux.intel.com> Content-Language: en-US From: Bryan O'Donoghue In-Reply-To: <20240531194723.1761567-2-andriy.shevchenko@linux.intel.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 31/05/2024 20:42, Andy Shevchenko wrote: > There are few drivers that use the same pattern to check if the transfer > is DMA mapped or not. Provide a helper. > > Signed-off-by: Andy Shevchenko > --- > drivers/spi/internals.h | 8 ++++++++ > 1 file changed, 8 insertions(+) > > diff --git a/drivers/spi/internals.h b/drivers/spi/internals.h > index 4a28a8395552..47a87c2a6979 100644 > --- a/drivers/spi/internals.h > +++ b/drivers/spi/internals.h > @@ -40,4 +40,12 @@ static inline void spi_unmap_buf(struct spi_controller *ctlr, > } > #endif /* CONFIG_HAS_DMA */ > > +static inline bool spi_xfer_is_dma_mapped(struct spi_controller *ctlr, > + struct spi_device *spi, > + struct spi_transfer *xfer) > +{ > + return ctlr->can_dma && ctlr->can_dma(ctlr, spi, xfer) && > + ctlr->cur_msg_mapped; > +} > + > #endif /* __LINUX_SPI_INTERNALS_H */ Reviewed-by: Bryan O'Donoghue