From: "Nuno Sá" <noname.nuno@gmail.com>
To: Marcelo Schmitt <marcelo.schmitt1@gmail.com>,
David Lechner <dlechner@baylibre.com>
Cc: Marcelo Schmitt <marcelo.schmitt@analog.com>,
broonie@kernel.org, lars@metafoo.de,
Michael.Hennerich@analog.com, jic23@kernel.org,
robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org,
conor+dt@kernel.org, nuno.sa@analog.com,
linux-iio@vger.kernel.org, devicetree@vger.kernel.org,
linux-spi@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3 4/6] spi: spi-axi-spi-engine: Add support for MOSI idle configuration
Date: Fri, 07 Jun 2024 09:15:54 +0200 [thread overview]
Message-ID: <04b1296ff98a0accbf962a4a4bafc2e85a9869ae.camel@gmail.com> (raw)
In-Reply-To: <ZmIqxS-xUVMNH_lJ@debian-BULLSEYE-live-builder-AMD64>
On Thu, 2024-06-06 at 18:31 -0300, Marcelo Schmitt wrote:
...
>
>
>
> When is a driver version check needed?
> Yes, older versions of SPI-Engine won't support this, but the patch set should
> cause no regression. Even if loading the current ad4000 driver with
> older SPI-Engine HDL and driver, the ADC driver would get a warn (or error?)
> and do what's possible without MOSI idle feature (probably only be able to do
> reg access) or fail probing.
>
Maybe I'm missing something but with the patchset we unconditionally set
SPI_MOSI_IDLE_HIGH. So if we load an hdl which does not support it things will
apparently be ok but it won't actually work, right? If I'm right we should have
a bit in a RO config_register telling us that the feature is being supported or
not. That way we only set the mode bit if we do support it...
- Nuno Sá
next prev parent reply other threads:[~2024-06-07 7:12 UTC|newest]
Thread overview: 40+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-06-04 22:40 [PATCH v3 0/6] Add support for AD4000 series of ADCs Marcelo Schmitt
2024-06-04 22:41 ` [PATCH v3 1/6] spi: Add SPI mode bit for MOSI idle state configuration Marcelo Schmitt
2024-06-05 9:14 ` Nuno Sá
2024-06-05 12:02 ` Mark Brown
2024-06-06 20:10 ` Marcelo Schmitt
2024-06-07 13:52 ` Mark Brown
2024-06-05 12:24 ` Mark Brown
2024-06-05 16:37 ` David Lechner
2024-06-05 17:04 ` Mark Brown
2024-06-06 22:08 ` Marcelo Schmitt
2024-06-07 13:51 ` Mark Brown
2024-06-06 19:57 ` Marcelo Schmitt
2024-06-07 13:50 ` Mark Brown
2024-06-07 14:55 ` Marcelo Schmitt
2024-06-04 22:42 ` [PATCH v3 2/6] spi: bitbang: Implement support " Marcelo Schmitt
2024-06-05 9:30 ` Nuno Sá
2024-06-04 22:42 ` [PATCH v3 3/6] spi: spi-gpio: Add " Marcelo Schmitt
2024-06-05 9:26 ` Nuno Sá
2024-06-04 22:43 ` [PATCH v3 4/6] spi: spi-axi-spi-engine: Add support for MOSI idle configuration Marcelo Schmitt
2024-06-05 9:25 ` Nuno Sá
2024-06-05 17:03 ` David Lechner
2024-06-06 6:51 ` Nuno Sá
2024-06-06 13:21 ` David Lechner
2024-06-06 21:31 ` Marcelo Schmitt
2024-06-07 7:15 ` Nuno Sá [this message]
2024-06-07 14:40 ` Marcelo Schmitt
2024-06-09 9:11 ` Jonathan Cameron
2024-06-04 22:43 ` [PATCH v3 5/6] dt-bindings: iio: adc: Add AD4000 Marcelo Schmitt
2024-06-05 17:14 ` Conor Dooley
2024-06-07 14:35 ` Marcelo Schmitt
2024-06-07 14:49 ` Conor Dooley
2024-06-05 9:31 ` [PATCH v3 0/6] Add support for AD4000 series of ADCs Nuno Sá
2024-06-05 11:19 ` Marcelo Schmitt
2024-06-05 11:14 ` [PATCH v3 6/6] iio: adc: Add support for AD4000 Marcelo Schmitt
2024-06-05 13:03 ` Nuno Sá
2024-06-09 9:23 ` Jonathan Cameron
2024-06-11 10:34 ` Andy Shevchenko
2024-06-11 17:05 ` Jonathan Cameron
2024-06-05 20:50 ` kernel test robot
2024-06-05 21:32 ` kernel test robot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=04b1296ff98a0accbf962a4a4bafc2e85a9869ae.camel@gmail.com \
--to=noname.nuno@gmail.com \
--cc=Michael.Hennerich@analog.com \
--cc=broonie@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=dlechner@baylibre.com \
--cc=jic23@kernel.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=lars@metafoo.de \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-spi@vger.kernel.org \
--cc=marcelo.schmitt1@gmail.com \
--cc=marcelo.schmitt@analog.com \
--cc=nuno.sa@analog.com \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).