From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from szxga07-in.huawei.com (szxga07-in.huawei.com [45.249.212.35]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 0B7681FDD; Fri, 6 Sep 2024 03:31:21 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=45.249.212.35 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1725593484; cv=none; b=WVjy3trB8zGDcg8IdeT9bfEISxwkv6ejhU2X81dx1qVSOuOIuufkaaAdayUCMkPIWGjWkpPIF8gYQqhNyxss/9mh928X1kpyPByMVDgFXuYY/QDf9ZsywfMNvAnzgmsUEP+RHY5OhSXku6mpM4SqvmyjeTgaXhnn0S3kjJ7bYIo= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1725593484; c=relaxed/simple; bh=yBhgBup16KWZms27emIVJJezntYNW98QpVj5ShaBhJA=; h=Message-ID:Date:MIME-Version:Subject:To:CC:References:From: In-Reply-To:Content-Type; b=sCgNy6RLMbUEmJSRjb5xCHz2Zvi9Pugok7+tcchjNH2iD9r17phBLhjIlHiJH9UBNlurd3h/Zp7wno16cihZrtaTMxOoERSchSj+62v5crx6wp+xnOd8XY8tu7ZTJswouA0/6gIdzxQ+c5czZciUecfs9kxMDnvTORzbtBSyDI4= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=huawei.com; spf=pass smtp.mailfrom=huawei.com; arc=none smtp.client-ip=45.249.212.35 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=huawei.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=huawei.com Received: from mail.maildlp.com (unknown [172.19.88.214]) by szxga07-in.huawei.com (SkyGuard) with ESMTP id 4X0MFX0rg0z1S9sH; Fri, 6 Sep 2024 11:30:56 +0800 (CST) Received: from kwepemh500013.china.huawei.com (unknown [7.202.181.146]) by mail.maildlp.com (Postfix) with ESMTPS id 388F61A016C; Fri, 6 Sep 2024 11:31:19 +0800 (CST) Received: from [10.67.109.254] (10.67.109.254) by kwepemh500013.china.huawei.com (7.202.181.146) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1544.11; Fri, 6 Sep 2024 11:31:18 +0800 Message-ID: <050a6434-00f9-4bba-a122-52c3a23fcf70@huawei.com> Date: Fri, 6 Sep 2024 11:31:17 +0800 Precedence: bulk X-Mailing-List: linux-spi@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.2.0 Subject: Re: [PATCH v2 2/2] spi: spi-geni-qcom: Fix missing undo runtime PM changes at driver exit time Content-Language: en-US To: Dmitry Baryshkov CC: , , , , , References: <20240906031345.1052241-1-ruanjinjie@huawei.com> <20240906031345.1052241-3-ruanjinjie@huawei.com> From: Jinjie Ruan In-Reply-To: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit X-ClientProxiedBy: dggems703-chm.china.huawei.com (10.3.19.180) To kwepemh500013.china.huawei.com (7.202.181.146) On 2024/9/6 11:15, Dmitry Baryshkov wrote: > On Fri, Sep 06, 2024 at 11:13:45AM GMT, Jinjie Ruan wrote: >> It's important to undo pm_runtime_use_autosuspend() with >> pm_runtime_dont_use_autosuspend() at driver exit time unless driver >> initially enabled pm_runtime with devm_pm_runtime_enable() >> (which handles it for you). >> >> Hence, call pm_runtime_dont_use_autosuspend() at driver exit time >> to fix it. >> >> Fixes: cfdab2cd85ec ("spi: spi-geni-qcom: Set an autosuspend delay of 250 ms") >> --- >> v2: >> - Fix it directly instead of use devm_pm_runtime_enable(). > > Why? The devm* sequence will have some problem, which will not consistent with the former. Link: https://lore.kernel.org/all/CAD=FV=VyDk-e2KNiuiBcACFAdrQmihOH6X6BSpGB+T1MsgsiKw@mail.gmail.com/ > >> --- >> drivers/spi/spi-geni-qcom.c | 2 ++ >> 1 file changed, 2 insertions(+) >> >> diff --git a/drivers/spi/spi-geni-qcom.c b/drivers/spi/spi-geni-qcom.c >> index fc2819effe2d..38857edbc785 100644 >> --- a/drivers/spi/spi-geni-qcom.c >> +++ b/drivers/spi/spi-geni-qcom.c >> @@ -1158,6 +1158,7 @@ static int spi_geni_probe(struct platform_device *pdev) >> spi_geni_release_dma: >> spi_geni_release_dma_chan(mas); >> spi_geni_probe_runtime_disable: >> + pm_runtime_dont_use_autosuspend(dev); >> pm_runtime_disable(dev); >> return ret; >> } >> @@ -1174,6 +1175,7 @@ static void spi_geni_remove(struct platform_device *pdev) >> >> spi_geni_release_dma_chan(mas); >> >> + pm_runtime_dont_use_autosuspend(&pdev->dev); >> pm_runtime_disable(&pdev->dev); >> } >> >> -- >> 2.34.1 >> >