From: Krzysztof Kozlowski <krzk@kernel.org>
To: Riccardo Mereu <r.mereu.kernel@arduino.cc>,
andersson@kernel.org, konradybcio@kernel.org, robh@kernel.org,
krzk+dt@kernel.org, conor+dt@kernel.org, broonie@kernel.org
Cc: linux@roeck-us.net, Jonathan.Cameron@huawei.com,
wenswang@yeah.net, naresh.solanki@9elements.com,
michal.simek@amd.com, nuno.sa@analog.com, chou.cosmo@gmail.com,
grantpeltier93@gmail.com, eajames@linux.ibm.com,
farouk.bouabid@cherry.de, linux-arm-msm@vger.kernel.org,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-spi@vger.kernel.org, m.facchin@arduino.cc,
Riccardo Mereu <r.mereu@arduino.cc>
Subject: Re: [PATCH v3 6/6] arm64: dts: qcom: qrb2210: add dts for Arduino unoq
Date: Thu, 20 Nov 2025 17:59:17 +0100 [thread overview]
Message-ID: <0ce7b889-f03d-4a41-8866-e137ad45e77b@kernel.org> (raw)
In-Reply-To: <20251120155825.121483-7-r.mereu.kernel@arduino.cc>
On 20/11/2025 16:58, Riccardo Mereu wrote:
> From: Riccardo Mereu <r.mereu@arduino.cc>
>
> Arduino UnoQ is a single-board computer combining Qualcomm
> Dragonwing™ QRB2210 microprocessor with STMicroelectronics STM32U585
> microcontroller.
> Support to a simply boot to shell environment includes:
> - UART, I2C, SPI
> - onboard LEDS
> - eMMC
> - WLAN and BT
>
> Signed-off-by: Riccardo Mereu <r.mereu@arduino.cc>
> ---
> arch/arm64/boot/dts/qcom/Makefile | 1 +
> .../boot/dts/qcom/qrb2210-arduino-imola.dts | 459 ++++++++++++++++++
> 2 files changed, 460 insertions(+)
> create mode 100644 arch/arm64/boot/dts/qcom/qrb2210-arduino-imola.dts
>
> +
> +&spi5 {
> + status = "okay";
> +
> + spidev@0 {
> + reg = <0>;
> + compatible = "arduino,unoq-mcu";
If there is going to be new version (no need to resend just for that):
Please re-order these two, compatible is always the fist property, reg
follows, see also DTS coding style.
Reviewed-by: Krzysztof Kozlowski <krzk@kernel.org>
Best regards,
Krzysztof
next prev parent reply other threads:[~2025-11-20 16:59 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-11-20 15:58 [PATCH v3 0/6] arm64: qcom: add support for Arduino UnoQ SBC Riccardo Mereu
2025-11-20 15:58 ` [PATCH v3 1/6] dt-bindings: vendor-prefixes: Add Arduino name Riccardo Mereu
2025-11-20 16:56 ` Krzysztof Kozlowski
2025-11-20 15:58 ` [PATCH v3 2/6] dt-bindings: trivial-devices: add arduino spi mcu interface Riccardo Mereu
2025-11-20 16:57 ` Krzysztof Kozlowski
2025-11-20 15:58 ` [PATCH v3 3/6] spi: spidev: add compatible for " Riccardo Mereu
2025-11-20 16:57 ` Krzysztof Kozlowski
2025-11-20 15:58 ` [PATCH v3 4/6] dt-bindings: arm: qcom: Add arduino imola, UnoQ codename Riccardo Mereu
2025-11-20 15:58 ` [PATCH v3 5/6] arm64: dts: qcom: agatti: add uart2 node Riccardo Mereu
2025-11-20 15:58 ` [PATCH v3 6/6] arm64: dts: qcom: qrb2210: add dts for Arduino unoq Riccardo Mereu
2025-11-20 16:59 ` Krzysztof Kozlowski [this message]
2025-11-21 14:05 ` Dmitry Baryshkov
2025-11-24 11:44 ` Konrad Dybcio
2025-11-26 9:27 ` Riccardo Mereu Linux Kernel
2025-11-26 14:03 ` Loic Poulain
2025-11-27 10:35 ` Konrad Dybcio
2025-11-21 14:39 ` (subset) [PATCH v3 0/6] arm64: qcom: add support for Arduino UnoQ SBC Mark Brown
2026-01-05 14:07 ` Bjorn Andersson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0ce7b889-f03d-4a41-8866-e137ad45e77b@kernel.org \
--to=krzk@kernel.org \
--cc=Jonathan.Cameron@huawei.com \
--cc=andersson@kernel.org \
--cc=broonie@kernel.org \
--cc=chou.cosmo@gmail.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=eajames@linux.ibm.com \
--cc=farouk.bouabid@cherry.de \
--cc=grantpeltier93@gmail.com \
--cc=konradybcio@kernel.org \
--cc=krzk+dt@kernel.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-spi@vger.kernel.org \
--cc=linux@roeck-us.net \
--cc=m.facchin@arduino.cc \
--cc=michal.simek@amd.com \
--cc=naresh.solanki@9elements.com \
--cc=nuno.sa@analog.com \
--cc=r.mereu.kernel@arduino.cc \
--cc=r.mereu@arduino.cc \
--cc=robh@kernel.org \
--cc=wenswang@yeah.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox