From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wr1-f52.google.com (mail-wr1-f52.google.com [209.85.221.52]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 9F59413CA87 for ; Mon, 3 Jun 2024 22:53:40 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.52 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1717455222; cv=none; b=gDW5vL2Usr2NDVI2ZlVMgVMr/KW08RnXasaFgYYwndKo4FFuUj8a4Uc0cZ/A5tT/XcgMOeHBWrIoOdkr85pOAR3tyhk77xsk1xktG2ipNNrrramM6pMLhw+ZXutuHJWcyUl9aIg7WYKNU/C3C/awqrp0+ORBh+PlGklAyNpC3mk= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1717455222; c=relaxed/simple; bh=1O+jSFdxFVgeNXpaSM+18pB8mEWHTJkOio0TJRlnCDE=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=hqYtQK22/wF7e58FtU0/gsw1BNcn66V1Xczigoe4Nj38ANbGp02riV4pevWe1a+OTNLV/vtNiAtj2r8P3LWksOZ/aJj3TEFLXApt5NwfP6CIO3M89MwjVJLsz6k6HtG3aX+lNK16j8GhxBlT9xj1uNKc17MVTu04HHoIyEsRNJ4= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=CUMtuqwC; arc=none smtp.client-ip=209.85.221.52 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="CUMtuqwC" Received: by mail-wr1-f52.google.com with SMTP id ffacd0b85a97d-35dca73095aso4096268f8f.0 for ; Mon, 03 Jun 2024 15:53:40 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1717455219; x=1718060019; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=0HZ5LR9brtVaXPPFehubrQnp6b27zagXRHlQw/mMZDc=; b=CUMtuqwCXn8Q6+SYTWyEiUju5EWibETkv7L/4xkAxqqJw060vh2CxbcILvLD7t6zsN Tn7dhGiGFMlhCHfpDjtFtGTQdBSVEJwbsFf+iNCTgNd7Hq+Pjqe8IXp9J4SUaaS0S0P0 5z41nIR3KubhhQFhRwL/JIFYWPwB+adII241v+mI4fNX1txq4wavaekHaExDHIfWQf6N l4P3u+BbFuRUUJs4b1b/g+J4kEMRMiL4v3b0nqnrRV8yXMSSi5vuiyHiiJjj1F3JVwfY UPkoxX5aoQlit8J2GRUy02JJSw9blzwXsbVzxbxj+Zx0/Ih8x/r3y2njRJDkFSbpIg9h xo2g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1717455219; x=1718060019; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=0HZ5LR9brtVaXPPFehubrQnp6b27zagXRHlQw/mMZDc=; b=g2QbPOr+Qc7AOOPVfpfF3l7pzAlii6hAvnKbXBhgyy9GRdTq6Tnq1jko2UKjlit+dF agSkir+slRABzhgcbv1qLlCYqQejmglqKPknIe3gIi90RjPcB3Ly2yGjuzkH3TttJlHa R6HP0cpJNNEH8gWD7A/sJlneVx3W+sxryCo6EAaGUf7mRs4PhfreD9YL6iVD1MRg6Jjb AtjuQOb40syav0sxlYJTujZ5YF0RHnMWjJPcFtfP1DJvVI0ovdd+CJenhJXERoIsbrJZ K5aBnga96nbtqxfGTdg+sIx/eQY5sX2o4uDVX7KQSfITX0xIK5R3gvGJRENjD4XWlvGA jEDQ== X-Forwarded-Encrypted: i=1; AJvYcCUJvCj3SPHLoSO1QH6h4Y+9YCz0wzwr2x8RB3o4CzX/wQvSDi63md5sEyLpICk3JsU4bsqTg/nfv/U7Gcdj2EGdAjKPCU9xcH1l X-Gm-Message-State: AOJu0YznFjOpzcV7ghxjNZ814P9ylGnqviaPEtc/pgTXXBgsJJNzt5PI ew712XFmto7Y08XikfiPmhcLQGs9chAbWiYbJqJYSE5QrOYVccbQiYGjQIJJvkc= X-Google-Smtp-Source: AGHT+IGw7uz1nVwn4Qwm3BlhI2Nm0K84pczwRY0EoHObHQ8kx0Cv64cwJ1Ocvd4pkhwBDj11rt9Qaw== X-Received: by 2002:a05:6000:1282:b0:354:f944:11de with SMTP id ffacd0b85a97d-35e0f2869f4mr7171255f8f.28.1717455218902; Mon, 03 Jun 2024 15:53:38 -0700 (PDT) Received: from [192.168.0.3] ([176.61.106.227]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-35dd04c0f1fsm10038807f8f.15.2024.06.03.15.53.37 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 03 Jun 2024 15:53:38 -0700 (PDT) Message-ID: <0f3f0b35-b13e-438c-bf55-7fb0064b61cf@linaro.org> Date: Mon, 3 Jun 2024 23:53:37 +0100 Precedence: bulk X-Mailing-List: linux-spi@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v1 7/8] spi: qup: Use new spi_xfer_is_dma_mapped() helper To: Andy Shevchenko , Mark Brown , Yang Yingliang , Christophe JAILLET , Thangaraj Samynathan , linux-spi@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-arm-msm@vger.kernel.org Cc: Serge Semin , Daniel Mack , Haojian Zhuang , Robert Jarzmik , =?UTF-8?Q?N=C3=ADcolas_F_=2E_R_=2E_A_=2E_Prado?= , Neil Armstrong References: <20240531194723.1761567-1-andriy.shevchenko@linux.intel.com> <20240531194723.1761567-8-andriy.shevchenko@linux.intel.com> Content-Language: en-US From: Bryan O'Donoghue In-Reply-To: <20240531194723.1761567-8-andriy.shevchenko@linux.intel.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 31/05/2024 20:42, Andy Shevchenko wrote: > Replace a few lines of code by calling a spi_xfer_is_dma_mapped() helper. > > Signed-off-by: Andy Shevchenko > --- > drivers/spi/spi-qup.c | 9 ++++----- > 1 file changed, 4 insertions(+), 5 deletions(-) > > diff --git a/drivers/spi/spi-qup.c b/drivers/spi/spi-qup.c > index 2af63040ac6e..06da4aa7eeb7 100644 > --- a/drivers/spi/spi-qup.c > +++ b/drivers/spi/spi-qup.c > @@ -5,6 +5,8 @@ > > #include > #include > +#include > +#include > #include > #include > #include > @@ -16,8 +18,7 @@ > #include > #include > #include > -#include > -#include > +#include "internals.h" > > #define QUP_CONFIG 0x0000 > #define QUP_STATE 0x0004 > @@ -709,9 +710,7 @@ static int spi_qup_io_prep(struct spi_device *spi, struct spi_transfer *xfer) > > if (controller->n_words <= (controller->in_fifo_sz / sizeof(u32))) > controller->mode = QUP_IO_M_MODE_FIFO; > - else if (spi->controller->can_dma && > - spi->controller->can_dma(spi->controller, spi, xfer) && > - spi->controller->cur_msg_mapped) > + else if (spi_xfer_is_dma_mapped(spi->controller, spi, xfer)) > controller->mode = QUP_IO_M_MODE_BAM; > else > controller->mode = QUP_IO_M_MODE_BLOCK; Reviewed-by: Bryan O'Donoghue