From: Arnd Bergmann <arnd-r2nGTMty4D4@public.gmane.org>
To: Stefan Roese <sr-ynQEQJNshbs@public.gmane.org>
Cc: linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org,
linux-spi-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
Thomas Petazzoni
<thomas.petazzoni-wi1+55ScJUtKEb57/3fJTNBPR1lH4CV8@public.gmane.org>,
Gregory CLEMENT
<gregory.clement-wi1+55ScJUtKEb57/3fJTNBPR1lH4CV8@public.gmane.org>,
Andrew Lunn <andrew-g2DYL2Zd6BY@public.gmane.org>,
Mark Brown <broonie-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
Subject: Re: [PATCH v3] spi: orion.c: Add direct access mode
Date: Sat, 16 Apr 2016 22:06:50 +0200 [thread overview]
Message-ID: <10734204.V6uBDOOZ6M@wuerfel> (raw)
In-Reply-To: <1460030811-13787-1-git-send-email-sr-ynQEQJNshbs@public.gmane.org>
On Thursday 07 April 2016 14:06:51 Stefan Roese wrote:
> v3:
> - Used static MBus windows again, as suggested by Arnd
> - No new DT bindings needed for this. The MBus windows need to be
> configured in the 'reg' property of the SPI controller. This is
> done in a separate patch for the Armada platforms.
> - The direct mapping is configured and enable by adding the
> specific MBus entry to the 'ranges' property of the 'soc' node
> in the board dts file.
The new approach looks good to me, thanks!
As Mark pointed out, you still need to document the fact that
the SPI controller can now have additional entries in its 'reg'
property, and it would be nice to reference the mbus binding
from the spi controller binding as a help for people that
want to enable the direct mode.
Arnd
--
To unsubscribe from this list: send the line "unsubscribe linux-spi" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
prev parent reply other threads:[~2016-04-16 20:06 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-04-07 12:06 [PATCH v3] spi: orion.c: Add direct access mode Stefan Roese
[not found] ` <1460030811-13787-1-git-send-email-sr-ynQEQJNshbs@public.gmane.org>
2016-04-11 10:57 ` Mark Brown
[not found] ` <20160411105740.GB3351-GFdadSzt00ze9xe1eoZjHA@public.gmane.org>
2016-04-12 11:43 ` Stefan Roese
[not found] ` <570CDF5F.9070106-ynQEQJNshbs@public.gmane.org>
2016-04-12 19:27 ` Mark Brown
[not found] ` <20160412192736.GC14664-GFdadSzt00ze9xe1eoZjHA@public.gmane.org>
2016-04-13 5:30 ` Stefan Roese
[not found] ` <570DD967.8010703-ynQEQJNshbs@public.gmane.org>
2016-04-13 5:59 ` Mark Brown
[not found] ` <20160413055946.GH14664-GFdadSzt00ze9xe1eoZjHA@public.gmane.org>
2016-04-13 11:40 ` Stefan Roese
[not found] ` <570E3010.10309-ynQEQJNshbs@public.gmane.org>
2016-04-13 17:20 ` Mark Brown
2016-04-16 20:06 ` Arnd Bergmann [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=10734204.V6uBDOOZ6M@wuerfel \
--to=arnd-r2ngtmty4d4@public.gmane.org \
--cc=andrew-g2DYL2Zd6BY@public.gmane.org \
--cc=broonie-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org \
--cc=gregory.clement-wi1+55ScJUtKEb57/3fJTNBPR1lH4CV8@public.gmane.org \
--cc=linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org \
--cc=linux-spi-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=sr-ynQEQJNshbs@public.gmane.org \
--cc=thomas.petazzoni-wi1+55ScJUtKEb57/3fJTNBPR1lH4CV8@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox