From: Mikhail Kshevetskiy <mikhail.kshevetskiy@iopsys.eu>
To: Krzysztof Kozlowski <krzk@kernel.org>,
Matthias Brugger <matthias.bgg@gmail.com>,
AngeloGioacchino Del Regno
<angelogioacchino.delregno@collabora.com>,
Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
Lorenzo Bianconi <lorenzo@kernel.org>,
Ray Liu <ray.liu@airoha.com>, Mark Brown <broonie@kernel.org>,
Andy Shevchenko <andy@kernel.org>,
linux-arm-kernel@lists.infradead.org,
linux-mediatek@lists.infradead.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org, linux-spi@vger.kernel.org
Cc: Andreas Gnau <andreas.gnau@iopsys.eu>
Subject: Re: [PATCH v9 15/15] arm: dts: airoha: en7523: add SNAND node
Date: Sat, 11 Oct 2025 08:01:59 +0300 [thread overview]
Message-ID: <10802039-ca65-41c0-88fa-51db6d86aabd@iopsys.eu> (raw)
In-Reply-To: <34899379-9788-4ac8-8b62-e9f47b4d49d9@kernel.org>
On 11.10.2025 02:42, Krzysztof Kozlowski wrote:
> On 10/10/2025 22:45, Mikhail Kshevetskiy wrote:
>> Add SNAND node to enable support of attached SPI-NAND on the EN7523 SoC.
>>
>> Signed-off-by: Mikhail Kshevetskiy <mikhail.kshevetskiy@iopsys.eu>
>> ---
>> arch/arm/boot/dts/airoha/en7523.dtsi | 21 +++++++++++++++++++++
>> 1 file changed, 21 insertions(+)
>>
>> diff --git a/arch/arm/boot/dts/airoha/en7523.dtsi b/arch/arm/boot/dts/airoha/en7523.dtsi
>> index b523a868c4ad..78e351eb787a 100644
>> --- a/arch/arm/boot/dts/airoha/en7523.dtsi
>> +++ b/arch/arm/boot/dts/airoha/en7523.dtsi
>> @@ -203,4 +203,25 @@ pcie_intc1: interrupt-controller {
>> #interrupt-cells = <1>;
>> };
>> };
>> +
>> + spi_ctrl: spi@1fa10000 {
>> + compatible = "airoha,en7581-snand";
> NAK, now I found this... Respond to comments instead of ignoring them.
>
> Three versions within few hours, that's not acceptable. Outside of the
> merge window the expectation is minimum 24h difference. Within merge
> window this is just spamming.
I already lost any hope to merge this to linux-3.18, so no problem.
Could you and Rob explain me this compatible issue? I got a feeling that
Rob telling me to keep "airoha,en7581-snand" compatible while you are
telling the opposite. As for me the use of "airoha,en7523-snand" or
maybe "airoha,en75xx-snand" for both en7523 & en7581 chips is the best.
Is there any policy? Could you provide a link?
Regards,
Mikhail Kshevetskiy
>
> Best regards,
> Krzysztof
next prev parent reply other threads:[~2025-10-11 5:02 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-10-10 20:44 [PATCH v9 00/15] spi: airoha: driver fixes & improvements Mikhail Kshevetskiy
2025-10-10 20:44 ` [PATCH v9 01/15] spi: airoha: return an error for continuous mode dirmap creation cases Mikhail Kshevetskiy
2025-10-10 20:44 ` [PATCH v9 02/15] spi: airoha: remove unnecessary restriction length Mikhail Kshevetskiy
2025-10-10 20:44 ` [PATCH v9 03/15] spi: airoha: add support of dual/quad wires spi modes to exec_op() handler Mikhail Kshevetskiy
2025-10-10 20:44 ` [PATCH v9 04/15] spi: airoha: remove unnecessary switch to non-dma mode Mikhail Kshevetskiy
2025-10-10 20:44 ` [PATCH v9 05/15] spi: airoha: switch back to non-dma mode in the case of error Mikhail Kshevetskiy
2025-10-10 20:44 ` [PATCH v9 06/15] spi: airoha: fix reading/writing of flashes with more than one plane per lun Mikhail Kshevetskiy
2025-10-10 20:44 ` [PATCH v9 07/15] spi: airoha: unify dirmap read/write code Mikhail Kshevetskiy
2025-10-10 20:44 ` [PATCH v9 08/15] spi: airoha: support of dualio/quadio flash reading commands Mikhail Kshevetskiy
2025-10-10 20:44 ` [PATCH v9 09/15] spi: airoha: avoid setting of page/oob sizes in REG_SPI_NFI_PAGEFMT Mikhail Kshevetskiy
2025-10-10 20:44 ` [PATCH v9 10/15] spi: airoha: reduce the number of modification of REG_SPI_NFI_CNFG and REG_SPI_NFI_SECCUS_SIZE registers Mikhail Kshevetskiy
2025-10-10 20:44 ` [PATCH v9 11/15] spi: airoha: set custom sector size equal to flash page size Mikhail Kshevetskiy
2025-10-10 20:44 ` [PATCH v9 12/15] spi: airoha: avoid reading flash page settings from SNFI registers during driver startup Mikhail Kshevetskiy
2025-10-10 20:44 ` [PATCH v9 13/15] spi: airoha: buffer must be 0xff-ed before writing Mikhail Kshevetskiy
2025-10-10 20:44 ` [PATCH v9 14/15] spi: airoha-snfi: en7523: workaround flash damaging if UART_TXD was short to GND Mikhail Kshevetskiy
2025-10-10 20:45 ` [PATCH v9 15/15] arm: dts: airoha: en7523: add SNAND node Mikhail Kshevetskiy
2025-10-10 23:42 ` Krzysztof Kozlowski
2025-10-11 5:01 ` Mikhail Kshevetskiy [this message]
2025-10-12 2:48 ` Krzysztof Kozlowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=10802039-ca65-41c0-88fa-51db6d86aabd@iopsys.eu \
--to=mikhail.kshevetskiy@iopsys.eu \
--cc=andreas.gnau@iopsys.eu \
--cc=andy@kernel.org \
--cc=angelogioacchino.delregno@collabora.com \
--cc=broonie@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=krzk+dt@kernel.org \
--cc=krzk@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=linux-spi@vger.kernel.org \
--cc=lorenzo@kernel.org \
--cc=matthias.bgg@gmail.com \
--cc=ray.liu@airoha.com \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).