From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from szxga07-in.huawei.com (szxga07-in.huawei.com [45.249.212.35]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 7A503185B7D; Fri, 13 Sep 2024 06:44:33 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=45.249.212.35 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1726209876; cv=none; b=udwZvq1hNg3LE6Zh32/NdRAGCBDFRHpVcA/w0FrBnhmRknC3I4qUh+wiWqxLyCRPV1bGpGQ2ShMjq/iy8hnDzaogp9yWlthzyXsGmOHiCAjMLjIeeDrjbSRhgwDOz1umloN1c5rg5BcIHXVHWIuedEsrGAsRl8KBGQ4DL61TuFE= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1726209876; c=relaxed/simple; bh=Y4gAKBrqddVEd+BMdZmluzEb9FZKc6UupnqYVWyoNHs=; h=Message-ID:Date:MIME-Version:Subject:To:CC:References:From: In-Reply-To:Content-Type; b=COY/YlSefyXEfNSdB/hXlXYecdeSCQhxwECDPJhWAV9viP2eRs8mrNGiQiq1t+x4+5KFfa7oA6UMMyN+ZfLTdLWG5/b7ww6ktmUHHBgHPAm28Z/ZbqB4NTRi+QsckHvb6Dq1w+BenpYMQ4xymr1CTKgEPw5ADtrwE+JhmbBIlxM= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=huawei.com; spf=pass smtp.mailfrom=huawei.com; arc=none smtp.client-ip=45.249.212.35 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=huawei.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=huawei.com Received: from mail.maildlp.com (unknown [172.19.88.234]) by szxga07-in.huawei.com (SkyGuard) with ESMTP id 4X4lC21vw7z1SBCm; Fri, 13 Sep 2024 14:43:58 +0800 (CST) Received: from kwepemh500013.china.huawei.com (unknown [7.202.181.146]) by mail.maildlp.com (Postfix) with ESMTPS id 87316140134; Fri, 13 Sep 2024 14:44:30 +0800 (CST) Received: from [10.67.109.254] (10.67.109.254) by kwepemh500013.china.huawei.com (7.202.181.146) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1544.11; Fri, 13 Sep 2024 14:44:29 +0800 Message-ID: <10e77c5a-a188-698b-0c82-86c4bcdf114d@huawei.com> Date: Fri, 13 Sep 2024 14:44:29 +0800 Precedence: bulk X-Mailing-List: linux-spi@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.2.0 Subject: Re: [PATCH v4 3/3] spi: geni-qcom: Use devm functions to simplify code Content-Language: en-US To: Doug Anderson CC: , , , , , References: <20240909132810.1296786-1-ruanjinjie@huawei.com> <20240909132810.1296786-4-ruanjinjie@huawei.com> From: Jinjie Ruan In-Reply-To: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit X-ClientProxiedBy: dggems705-chm.china.huawei.com (10.3.19.182) To kwepemh500013.china.huawei.com (7.202.181.146) On 2024/9/12 21:38, Doug Anderson wrote: > Hi, > > On Wed, Sep 11, 2024 at 8:53 PM Jinjie Ruan wrote: >> >>>> @@ -1132,6 +1134,12 @@ static int spi_geni_probe(struct platform_device *pdev) >>>> if (ret) >>>> return ret; >>>> >>>> + ret = devm_add_action_or_reset(dev, spi_geni_release_dma_chan, mas); >>>> + if (ret) { >>>> + dev_err(dev, "Unable to add action.\n"); >>>> + return ret; >>>> + } >>> >>> Use dev_err_probe() to simplify. >>> >>> ret = devm_add_action_or_reset(dev, spi_geni_release_dma_chan, mas); >>> if (ret) >>> return dev_err_probe(dev, ret, "Unable to add action.\n"); >> >> It seems that if it only return -ENOMEM or 0, using dev_err_probe() has >> not not much value for many community maintainers. > > While I won't insist, it still has some value to use dev_err_probe() > as I talked about in commit 7065f92255bb ("driver core: Clarify that > dev_err_probe() is OK even w/out -EPROBE_DEFER") The main difference is that when use dev_err_probe()，there will print anything on -ENOMEM now. > > -Doug