From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.3 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE, SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id AF309C433E6 for ; Mon, 15 Feb 2021 13:51:15 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 74DDC64E32 for ; Mon, 15 Feb 2021 13:51:15 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230326AbhBONvJ (ORCPT ); Mon, 15 Feb 2021 08:51:09 -0500 Received: from gecko.sbs.de ([194.138.37.40]:44134 "EHLO gecko.sbs.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230171AbhBONvH (ORCPT ); Mon, 15 Feb 2021 08:51:07 -0500 Received: from mail2.sbs.de (mail2.sbs.de [192.129.41.66]) by gecko.sbs.de (8.15.2/8.15.2) with ESMTPS id 11FDghJW013208 (version=TLSv1.2 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Mon, 15 Feb 2021 14:42:44 +0100 Received: from [139.22.41.241] ([139.22.41.241]) by mail2.sbs.de (8.15.2/8.15.2) with ESMTP id 11FDgh44012974; Mon, 15 Feb 2021 14:42:43 +0100 Subject: Re: [PATCH] spi: pca2xx-pci: Fix an issue about missing call to 'pci_free_irq_vectors()' To: Andy Shevchenko , Dejin Zheng Cc: daniel@zonque.org, haojian.zhuang@gmail.com, robert.jarzmik@free.fr, broonie@kernel.org, jarkko.nikula@linux.intel.com, linux-spi@vger.kernel.org, linux-kernel@vger.kernel.org References: <20210214145746.602770-1-zhengdejin5@gmail.com> From: Jan Kiszka Message-ID: <10fa1c64-6a7d-e995-f292-20dc6ce5ed62@siemens.com> Date: Mon, 15 Feb 2021 14:42:42 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.7.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-spi@vger.kernel.org On 15.02.21 14:22, Andy Shevchenko wrote: > On Sun, Feb 14, 2021 at 10:57:46PM +0800, Dejin Zheng wrote: >> Call to 'pci_free_irq_vectors()' are missing both in the error handling >> path of the probe function, and in the remove function. So add them. > > I'm wondering if you noticed that it's done by pcim_* API. > Perhaps you can introduce pcim_alloc_irq_vectors() or so and do not add these > calls at all? You mean as plain wrapper for pci_alloc_irq_vectors, just to document it's managed? > >> Fixes: 64e02cb0bdfc7c ("spi: pca2xx-pci: Allow MSI") > > No, it doesn't fix anything. > Ah, now I recall: imbalanced APIs. Jan -- Siemens AG, T RDA IOT Corporate Competence Center Embedded Linux