From: Michael Walle <michael@walle.cc>
To: Mark Brown <broonie@kernel.org>
Cc: linux-spi@vger.kernel.org, linux-kernel@vger.kernel.org,
"Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>,
"Vladimir Oltean" <olteanv@gmail.com>
Subject: Re: [RFC PATCH] spi: fix use-after-free of the add_lock mutex
Date: Wed, 10 Nov 2021 17:30:48 +0100 [thread overview]
Message-ID: <116159a7cf1e7cb3817aa31931b81d91@walle.cc> (raw)
In-Reply-To: <YYvy79HfTvy8hC5/@sirena.org.uk>
Am 2021-11-10 17:27, schrieb Mark Brown:
>> For reference, the kernel oops is:
>> [ 20.242505] Unable to handle kernel paging request at virtual
>> address 0042a2203dc65260
>> [ 20.250468] Mem abort info:
>> [ 20.253270] ESR = 0x96000044
>
> Please think hard before including complete backtraces in upstream
> reports, they are very large and contain almost no useful information
> relative to their size so often obscure the relevant content in your
> message. If part of the backtrace is usefully illustrative (it often is
> for search engines if nothing else) then it's usually better to pull
> out
> the relevant sections.
It was in the comments section of the patch, for exactly this purpose.
That's how you're doing it, no?
-michael
next prev parent reply other threads:[~2021-11-10 16:30 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-11-10 16:08 [RFC PATCH] spi: fix use-after-free of the add_lock mutex Michael Walle
2021-11-10 16:27 ` Mark Brown
2021-11-10 16:30 ` Michael Walle [this message]
2021-11-10 16:39 ` Mark Brown
2021-11-10 16:49 ` Andy Shevchenko
2021-11-10 17:28 ` Uwe Kleine-König
2021-11-11 5:19 ` Lukas Wunner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=116159a7cf1e7cb3817aa31931b81d91@walle.cc \
--to=michael@walle.cc \
--cc=broonie@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-spi@vger.kernel.org \
--cc=olteanv@gmail.com \
--cc=u.kleine-koenig@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).