From: Scott Ellis <scott@jumpnowtek.com>
To: Tony Lindgren <tony@atomide.com>
Cc: spi-devel-general@lists.sourceforge.net,
David Brownell <dbrownell@users.sourceforge.net>,
Grant Likely <grant.likely@secretlab.ca>,
Andrew Morton <akpm@linux-foundation.org>,
Roman Tereshonkov <roman.tereshonkov@nokia.com>,
linux-omap@vger.kernel.org,
Aaro Koskinen <Aaro.Koskinen@nokia.com>,
Kevin Hilman <khilman@deeprootsystems.com>
Subject: Re: [PATCH 2/6 Revised] SPI omap2_mcspi: Add max_clk_div field to mcspi platform config
Date: Mon, 15 Mar 2010 16:30:22 -0400 [thread overview]
Message-ID: <1268685022.8594.130.camel@quad> (raw)
In-Reply-To: <20100315163246.GT2900@atomide.com>
> Hmm now it looks like you're missing 3630 handling?
>
> If the max_clk_div is 0x0f for 2420 and 2430, then you
> can just check for cpu_is_omap24xx(). If it's only
> different for 2420, then you can check for cpu_is_omap2420().
>
> That way it should be more future proof, and you don't
> need to change it for new processors.
>
Anand Gadiyar <gadiyar <at> ti.com> verified 0x0f for the 2430.
I think SWPU177D is the correct TRM for the omap3630 and if so then 0x0c
is the correct value.
I did not verify the omap44xx value and just assumed similar to the
omap3's. My bad.
Can you or someone point me to links for the omap2420 and the omap44xx
TRMs? I'm not having any luck finding them.
Then it can be verified whether a cpu_is_omap24xx() check is sufficient.
It probably is.
Or if someone with access to those manuals could do a quick check...
It's the max value of the MCSPI_CHxCONF.CLKD register field.
next prev parent reply other threads:[~2010-03-15 20:30 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-03-12 15:21 [PATCH 2/6] SPI omap2_mcspi: Add max_clk_div field to mcspi platform config Scott Ellis
2010-03-12 17:21 ` Tony Lindgren
2010-03-14 17:25 ` [PATCH 2/6 Revised] " Scott Ellis
2010-03-15 16:32 ` Tony Lindgren
2010-03-15 18:03 ` Felipe Balbi
2010-03-15 18:52 ` Tony Lindgren
2010-03-15 19:16 ` Felipe Balbi
2010-03-15 19:29 ` Tony Lindgren
2010-03-15 19:31 ` Felipe Balbi
2010-03-15 20:06 ` Tony Lindgren
2010-03-15 20:30 ` Scott Ellis [this message]
2010-03-15 21:02 ` Tony Lindgren
2010-03-19 19:46 ` Scott Ellis
2010-03-19 20:38 ` Tony Lindgren
2010-05-24 14:26 ` Scott Ellis
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1268685022.8594.130.camel@quad \
--to=scott@jumpnowtek.com \
--cc=Aaro.Koskinen@nokia.com \
--cc=akpm@linux-foundation.org \
--cc=dbrownell@users.sourceforge.net \
--cc=grant.likely@secretlab.ca \
--cc=khilman@deeprootsystems.com \
--cc=linux-omap@vger.kernel.org \
--cc=roman.tereshonkov@nokia.com \
--cc=spi-devel-general@lists.sourceforge.net \
--cc=tony@atomide.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).