[PATCH] SPI: move PL022 probe call to subsys_initcall()

[PATCH] SPI: move PL022 probe call to subsys_initcall()

[Linus Walleij]

The PL022 SPI bus is sometimes used for early stuff like
regulators that need to be present at module_init() time, so
we move this to a subsys_initcall().

Cc: Lukasz Baj <lukasz.baj@tieto.com>
Signed-off-by: Linus Walleij <linus.walleij@stericsson.com>
---
 drivers/spi/amba-pl022.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/drivers/spi/amba-pl022.c b/drivers/spi/amba-pl022.c
index 3db5402..f958072 100644
--- a/drivers/spi/amba-pl022.c
+++ b/drivers/spi/amba-pl022.c
@@ -2324,7 +2324,7 @@ static int __init pl022_init(void)
 	return amba_driver_register(&pl022_driver);
 }
 
-module_init(pl022_init);
+subsys_initcall(pl022_init);
 
 static void __exit pl022_exit(void)
 {
-- 
1.6.3.3

Re: [PATCH] SPI: move PL022 probe call to subsys_initcall()

[Grant Likely]

On Mon, Sep 06, 2010 at 11:02:12AM +0200, Linus Walleij wrote:
> The PL022 SPI bus is sometimes used for early stuff like
> regulators that need to be present at module_init() time, so
> we move this to a subsys_initcall().
> 
> Cc: Lukasz Baj <lukasz.baj-++hxYGjEMp0AvxtiuMwx3w@public.gmane.org>
> Signed-off-by: Linus Walleij <linus.walleij-0IS4wlFg1OjSUeElwK9/Pw@public.gmane.org>

Applied, thanks.

Note on the subject line:  The preferred form for spi patches is:

    spi[/chip]: <description>

'spi' in the header and the optional driver name are both lowercase.
I fix patches up to match this form, but it is less work for me when I
don't have to.

g.

> ---
>  drivers/spi/amba-pl022.c |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
> 
> diff --git a/drivers/spi/amba-pl022.c b/drivers/spi/amba-pl022.c
> index 3db5402..f958072 100644
> --- a/drivers/spi/amba-pl022.c
> +++ b/drivers/spi/amba-pl022.c
> @@ -2324,7 +2324,7 @@ static int __init pl022_init(void)
>  	return amba_driver_register(&pl022_driver);
>  }
>  
> -module_init(pl022_init);
> +subsys_initcall(pl022_init);
>  
>  static void __exit pl022_exit(void)
>  {
> -- 
> 1.6.3.3
> 

------------------------------------------------------------------------------
This SF.net Dev2Dev email is sponsored by:

Show off your parallel programming skills.
Enter the Intel(R) Threading Challenge 2010.
http://p.sf.net/sfu/intel-thread-sfd

Re: [PATCH] SPI: move PL022 probe call to subsys_initcall()

[Linus Walleij]

2010/9/9 Grant Likely <grant.likely@secretlab.ca>:

> Note on the subject line:  The preferred form for spi patches is:
>
>    spi[/chip]: <description>

Ah OK I'll use that syntax henceforth. Thanks!

Linus Walleij