Re: [PATCH] spi: fixed some core weirdness

[David Brownell <david-b-yBeKhBN/0LDR7s880joybQ@public.gmane.org>]

On Thu, 2010-10-21 at 21:06 +0200, Linus Walleij wrote:
> Those things in the SPI core just strike me as particularly odd:
> dev_dbg() used in an obvious error branch, 

When debugging, that can be fine.  "return errcode..." is how the error
gets reported; callers can handle that ... but they never read or
parse dev_err() output.  dev_dbg() is for developers/debuggers.


> and then two hardcoded
> strings passed in as parameters.

Which reduced the text space used by the driver, by sharing parts
of the message that were not variable.  I realize that some folk really
don't care how much memory gets wasted by constant strings,
but wasting image space still seems like a foolish policy to me.

I wouldn't merge this.



------------------------------------------------------------------------------
Nokia and AT&T present the 2010 Calling All Innovators-North America contest
Create new apps & games for the Nokia N8 for consumers in  U.S. and Canada
$10 million total in prizes - $4M cash, 500 devices, nearly $6M in marketing
Develop with Nokia Qt SDK, Web Runtime, or Java and Publish to Ovi Store 
http://p.sf.net/sfu/nokia-dev2dev